Bug 162784

Summary: [SOUP] Simplify AuthenticationChallenge
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, bugs-noreply, buildbot, commit-queue, danw, gustavo, mcatanzaro, mrobinson, rniwa, svillar
Priority: P2 Keywords: Gtk, Soup
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 162777    
Bug Blocks:    
Attachments:
Description Flags
Patch
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-yosemite-wk2 none

Carlos Garcia Campos
Reported 2016-09-30 04:12:44 PDT
We don't really need to keep references to the SoupSession and SoupMessage in AuthenticationChallenge, the SoupNetworkSession callback already forwards the challenge to the right ResourceHandle.
Attachments
Patch (8.78 KB, patch)
2016-09-30 04:15 PDT, Carlos Garcia Campos 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.30 MB, application/zip)
2016-09-30 05:16 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-09-30 04:15:02 PDT
Created attachment 290325 [details] Patch
Build Bot
Comment 2 2016-09-30 05:16:29 PDT
Comment on attachment 290325 [details] Patch Attachment 290325 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2174711 New failing tests: fast/images/pixel-crack-image-background-webkit-transform-scale.html
Build Bot
Comment 3 2016-09-30 05:16:32 PDT
Created attachment 290328 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Alex Christensen
Comment 4 2016-09-30 07:28:27 PDT
Comment on attachment 290325 [details] Patch r=me gtk build failure will not exist once https://bugs.webkit.org/show_bug.cgi?id=162777 lands, right? mac-wk2 test failure unrelated because none of this code is compiled on mac.
Carlos Garcia Campos
Comment 5 2016-09-30 07:30:57 PDT
(In reply to comment #4) > Comment on attachment 290325 [details] > Patch > > r=me > gtk build failure will not exist once > https://bugs.webkit.org/show_bug.cgi?id=162777 lands, right? > mac-wk2 test failure unrelated because none of this code is compiled on mac. Right!
Carlos Garcia Campos
Comment 6 2016-10-03 03:44:47 PDT
Committed r206732: <http://trac.webkit.org/changeset/206732>
Note You need to log in before you can comment on or make changes to this bug.