Summary: | Adjust current networking logging | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||||||
Component: | WebKit2 | Assignee: | Keith Rollin <krollin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, japhet, koivisto | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 162233 | ||||||||||
Bug Blocks: | 162237 | ||||||||||
Attachments: |
|
Description
Keith Rollin
2016-09-19 14:19:04 PDT
Created attachment 289287 [details]
Patch
Created attachment 289294 [details]
Patch
Comment on attachment 289287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289287&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:141 > + if (!m_hasReceivedData) { > + RELEASE_LOG_IF_ALLOWED("didReceiveData: Started receiving data (pageID = %llu, frameID = %llu, resourceID = %llu)", m_trackingParameters.pageID, m_trackingParameters.frameID, m_trackingParameters.resourceID); > + m_hasReceivedData = true; > + } I think this patch includes also your previous patch. I think it's now fixed in patch 289294 in comment #2. Comment on attachment 289294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289294&action=review > Source/WebCore/loader/ResourceLoader.h:151 > + Frame* frame() const { return m_frame.get(); } Const accessors should generally return const objects: const Frame* frame() const { ... } Created attachment 289390 [details]
Patch
Comment on attachment 289390 [details] Patch Rejecting attachment 289390 [details] from review queue. krollin@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 289390 [details] Patch Clearing flags on attachment: 289390 Committed r206166: <http://trac.webkit.org/changeset/206166> All reviewed patches have been landed. Closing bug. |