Reduce logging from WebResourceLoader::didReceiveData

• Component: WebKit2
• Status: RESOLVED FIXED

[Keith Rollin]

Reduce the amount of logging performed by WebResourceLoader::didReceiveData when downloading resources -- only log once even if called multiple times for a single resource.

[Keith Rollin]

Created attachment 289259 [details]
Patch

[Keith Rollin]

Created attachment 289262 [details]
Patch

[Antti Koivisto]

Comment on attachment 289262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289262&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138
> +        RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size());

Should the message indicate that this was the first data received? It might be confusing if it appears that there was nothing more.

[Keith Rollin]

(In reply to comment #3)
> Comment on attachment 289262 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289262&action=review
> 
> > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138
> > +        RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size());
> 
> Should the message indicate that this was the first data received? It might
> be confusing if it appears that there was nothing more.

This will be addressed in Bug 162235.

[WebKit Commit Bot]

Comment on attachment 289262 [details]
Patch

Clearing flags on attachment: 289262

Committed r206123: <http://trac.webkit.org/changeset/206123>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.