Bug 162022

Summary: Atomics.h on Windows: remove seq_cst hack
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Web Template FrameworkAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
sam: review+
patch
none
patch none

JF Bastien
Reported 2016-09-15 09:52:32 PDT
I think the code may have the same issue on Windows as it did on GCC at -Os in this bug: https://bugs.webkit.org/show_bug.cgi?id=155371 Now that the functions are always inlined the Windows issue may be no more. Let's throw a patch at the bots and see if they're happy!
Attachments
patch (6.54 KB, patch)
2016-09-15 09:55 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
patch (3.97 KB, patch)
2016-09-15 09:55 PDT, JF Bastien 		sam: review+
DetailsFormatted DiffDiff
patch (3.98 KB, patch)
2016-09-27 12:22 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
patch (3.98 KB, patch)
2016-09-27 13:53 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2016-09-15 09:55:17 PDT
Created attachment 288961 [details] patch Throwing it to the bots, let's see if they're happy.
JF Bastien
Comment 2 2016-09-15 09:55:41 PDT
Created attachment 288962 [details] patch Wrong patch....
Sam Weinig
Comment 3 2016-09-15 12:28:14 PDT
Comment on attachment 288962 [details] patch Well, you should probably make sure the windows bot builds first.
JF Bastien
Comment 4 2016-09-15 13:20:45 PDT
(In reply to comment #3) > Comment on attachment 288962 [details] > patch > > Well, you should probably make sure the windows bot builds first. Yeah I was hoping it would fail because of my patch, or be green... it's failing without my patch :(
JF Bastien
Comment 5 2016-09-15 13:33:25 PDT
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 288962 [details] > > patch > > > > Well, you should probably make sure the windows bot builds first. > > Yeah I was hoping it would fail because of my patch, or be green... it's > failing without my patch :( Trying to fix it here: https://bugs.webkit.org/show_bug.cgi?id=162031
JF Bastien
Comment 6 2016-09-27 12:22:34 PDT
Created attachment 289996 [details] patch Windows build was fixed a while ago, rebasing and re-uploading since I wrote my patch a few days ago. Sam Weinig had r+'d the previous match.
JF Bastien
Comment 7 2016-09-27 13:53:02 PDT
Comment on attachment 289996 [details] patch Windows bot was temporarily borked again. Should be fixed now...
JF Bastien
Comment 8 2016-09-27 13:53:54 PDT
Created attachment 290005 [details] patch Same patch, Windows bot is now fixed.
Mark Lam
Comment 9 2016-09-27 15:55:50 PDT
Comment on attachment 290005 [details] patch r=me
WebKit Commit Bot
Comment 10 2016-09-27 16:23:17 PDT
Comment on attachment 290005 [details] patch Clearing flags on attachment: 290005 Committed r206468: <http://trac.webkit.org/changeset/206468>
WebKit Commit Bot
Comment 11 2016-09-27 16:23:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.