Bug 161967

Summary: [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Andy Estes <aestes>
Status: REOPENED ---    
Severity: Normal CC: aestes, commit-queue, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170496
Bug Depends on:    
Bug Blocks: 167594, 170365    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Ryan Haddad 2016-09-14 08:58:46 PDT
API test WebKit2.DataDetectionReferenceDate timing out

Encountered on iOS simulator after bots were upgraded to the iOS 10 SDK.

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/13/steps/run-api-tests/logs/stdio
Comment 1 Ryan Haddad 2016-09-15 10:02:10 PDT
Disabled test in http://trac.webkit.org/projects/webkit/changeset/205976 to get the bots back to green. We should look at this soon, though.
Comment 2 Ryan Haddad 2016-09-15 10:02:10 PDT
Disabled test in http://trac.webkit.org/projects/webkit/changeset/205976 to get the bots back to green. We should look at this soon, though.
Comment 3 Ryan Haddad 2016-09-15 10:02:42 PDT
Pro tip: don't double click the save changes button.
Comment 4 Andy Estes 2017-04-04 23:41:06 PDT
Created attachment 306264 [details]
Patch
Comment 5 Andy Estes 2017-04-04 23:42:10 PDT
*** Bug 170496 has been marked as a duplicate of this bug. ***
Comment 6 Andy Estes 2017-04-04 23:55:25 PDT
Created attachment 306266 [details]
Patch
Comment 7 WebKit Commit Bot 2017-04-05 00:36:09 PDT
Comment on attachment 306266 [details]
Patch

Clearing flags on attachment: 306266

Committed r214932: <http://trac.webkit.org/changeset/214932>
Comment 8 WebKit Commit Bot 2017-04-05 00:36:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Ryan Haddad 2017-04-05 13:16:52 PDT
Reverted r214932 for reason:

This change broke an internal build.

Committed r214964: <http://trac.webkit.org/changeset/214964>
Comment 10 Andy Estes 2017-04-14 12:45:07 PDT
Created attachment 307136 [details]
Patch
Comment 11 WebKit Commit Bot 2017-04-14 13:29:28 PDT
Comment on attachment 307136 [details]
Patch

Clearing flags on attachment: 307136

Committed r215371: <http://trac.webkit.org/changeset/215371>
Comment 12 WebKit Commit Bot 2017-04-14 13:29:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Ryan Haddad 2017-04-18 16:21:27 PDT
I still see this test timing out on the bots:

Tests that timed out:
  WebKit2.DataDetectionReferenceDate
  WebKit2.WKWebProcessPlugInRangeHandle

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/755
Comment 14 Andy Estes 2017-04-19 11:47:33 PDT
(In reply to Ryan Haddad from comment #13)
> I still see this test timing out on the bots:
> 
> Tests that timed out:
>   WebKit2.DataDetectionReferenceDate
>   WebKit2.WKWebProcessPlugInRangeHandle
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/755

From looking at https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)?numbuilds=50 these seem to be flaky failures. I can't reproduce locally in a Public SDK build, sadly. We should probably just disable the tests again until we have time to investigate.
Comment 15 Ryan Haddad 2017-04-21 15:56:13 PDT
Disabled test in http://trac.webkit.org/projects/webkit/changeset/215651