Bug 161595

Summary: run-bindings-tests fails since r205422
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161580
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2016-09-04 23:39:55 PDT
> FAIL: (JS) JSTestClassWithJSBuiltinConstructor.h > --- WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h 2016-06-27 13:08:07.537464007 -0700 > +++ /tmp/tmpIsGJea/JSTestClassWithJSBuiltinConstructor.h 2016-09-04 23:35:01.119239257 -0700 > @@ -84,5 +84,8 @@ > JSC::JSValue toJSNewlyCreated(JSC::ExecState*, JSDOMGlobalObject*, Ref<TestClassWithJSBuiltinConstructor>&&); > inline JSC::JSValue toJSNewlyCreated(JSC::ExecState* state, JSDOMGlobalObject* globalObject, RefPtr<TestClassWithJSBuiltinConstructor>&& impl) { return impl ? toJSNewlyCreated(state, globalObject, impl.releaseNonNull()) : JSC::jsNull(); } > > +template<> struct JSDOMWrapperConverterTraits<TestClassWithJSBuiltinConstructor> { > + using WrapperClass = JSTestClassWithJSBuiltinConstructor; > +}; > > } // namespace WebCore > > FAIL: (JS) JSTestClassWithJSBuiltinConstructor.cpp > --- WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp 2016-09-01 05:31:58.238514962 -0700 > +++ /tmp/tmpIsGJea/JSTestClassWithJSBuiltinConstructor.cpp 2016-09-04 23:35:01.119239257 -0700 > @@ -201,7 +201,7 @@ > // by adding the SkipVTableValidation attribute to the interface IDL definition > RELEASE_ASSERT(actualVTablePointer == expectedVTablePointer); > #endif > - return createWrapper<JSTestClassWithJSBuiltinConstructor, TestClassWithJSBuiltinConstructor>(globalObject, WTFMove(impl)); > + return createWrapper<TestClassWithJSBuiltinConstructor>(globalObject, WTFMove(impl)); > } > > JSC::JSValue toJS(JSC::ExecState* state, JSDOMGlobalObject* globalObject, TestClassWithJSBuiltinConstructor& impl)
Attachments
Patch (47.61 KB, patch)
2016-09-04 23:46 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2016-09-04 23:46:40 PDT
Created attachment 287933 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-05 10:27:49 PDT
Comment on attachment 287933 [details] Patch Clearing flags on attachment: 287933 Committed r205458: <http://trac.webkit.org/changeset/205458>
WebKit Commit Bot
Comment 3 2016-09-05 10:27:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.