Bug 161222

Summary: EWS should indicate which bot processed the patch
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161223
https://bugs.webkit.org/show_bug.cgi?id=161220
https://bugs.webkit.org/show_bug.cgi?id=161280
Attachments:
Description Flags
Proposed patch
dbates: review+
updated patch
none
Semi-reverting this patch none

Description Aakash Jain 2016-08-25 18:54:37 PDT
Currently, it is hard to find out which bot processed a patch. Current method is to ssh in all the bots and look into the logs. EWS should clearly indicate which patch is being processed by which bot.
Comment 1 Aakash Jain 2016-08-25 19:11:39 PDT
Created attachment 287062 [details]
Proposed patch
Comment 2 Daniel Bates 2016-08-25 20:23:15 PDT
Comment on attachment 287062 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287062&action=review

> Tools/QueueStatusServer/handlers/statusbubble.py:134
> +                bubble["details_message"] = (statuses[0].bot_id + ", Recent messages:\n\n"

Unit test?
Comment 3 Daniel Bates 2016-08-25 20:24:12 PDT
Comment on attachment 287062 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287062&action=review

>> Tools/QueueStatusServer/handlers/statusbubble.py:134
>> +                bubble["details_message"] = (statuses[0].bot_id + ", Recent messages:\n\n"
> 
> Unit test?

R => r ?
Comment 4 Aakash Jain 2016-08-26 02:05:12 PDT
Created attachment 287082 [details]
updated patch

Changed R => r in " Recent messages". Also added "Started processing patch" message to progress_statuses, without this EWS will consider this as failure status and make the status bubbles orange.

This particular code is in Tools/QueueStatusServer, we haven't maintained unit-tests for QueueStatusServer.
Comment 5 WebKit Commit Bot 2016-08-26 02:45:18 PDT
The commit-queue encountered the following flaky tests while processing attachment 287082 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2016-08-26 02:46:12 PDT
The commit-queue encountered the following flaky tests while processing attachment 287082 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2016-08-26 03:56:41 PDT
Comment on attachment 287082 [details]
updated patch

Clearing flags on attachment: 287082

Committed r205010: <http://trac.webkit.org/changeset/205010>
Comment 8 WebKit Commit Bot 2016-08-26 03:56:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Alexey Proskuryakov 2016-08-26 09:22:06 PDT
This seems somewhat confusing to me. A patch can move from one bot to another. If a test cycle finishes without a result, the lock is simply dropped, and any bot is free to pick up the patch for a retry.

Which of the bots is given here, the first one or the current one? In either case, we need to make it explicit in the status.
Comment 10 Aakash Jain 2016-08-26 10:38:36 PDT
In this patch, bot is shown only when patch is in processing, and it shows the first bot. Will write another patch to cover all the cases.
Comment 11 Aakash Jain 2016-08-29 11:40:41 PDT
https://bugs.webkit.org/show_bug.cgi?id=161280 covers all the cases. It shows bot number corresponding to each status message. e.g.: https://webkit-queues.webkit.org/patch/287182
Comment 12 Alexey Proskuryakov 2016-08-29 11:42:46 PDT
As far as I can tell, the bubble remains incorrect/confusing.
Comment 13 Aakash Jain 2016-08-29 11:43:59 PDT
yeah, should we revert the bubble change done in this bug, or try to display bot_id in each status message in the bubble?
Comment 14 Aakash Jain 2016-08-29 14:08:32 PDT
Created attachment 287322 [details]
Semi-reverting this patch

Removing bot id from status bubble. We still need other changes made in the previous patch.
Comment 15 Alexey Proskuryakov 2016-08-29 14:21:49 PDT
Re-opening for CQ to work on the new patch.
Comment 16 WebKit Commit Bot 2016-08-29 14:53:25 PDT
Comment on attachment 287322 [details]
Semi-reverting this patch

Clearing flags on attachment: 287322

Committed r205149: <http://trac.webkit.org/changeset/205149>
Comment 17 WebKit Commit Bot 2016-08-29 14:53:30 PDT
All reviewed patches have been landed.  Closing bug.