Summary: | webkit-queues queue-status page should should list more recent statuses | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dbates, lforschler | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=161223 https://bugs.webkit.org/show_bug.cgi?id=161222 |
||||||||
Attachments: |
|
Description
Aakash Jain
2016-08-25 17:41:06 PDT
Created attachment 287058 [details]
Proposed patch
Comment on attachment 287058 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=287058&action=review > Tools/QueueStatusServer/handlers/queuestatus.py:65 > + return statuses.order("-date").fetch(50) Can we add a unit test? Comment on attachment 287058 [details] Proposed patch Attachment 287058 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1944208 New failing tests: fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden.html Created attachment 287075 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Comment on attachment 287058 [details]
Proposed patch
We haven't maintained unit-tests for QueueStatusServer.
Comment on attachment 287058 [details] Proposed patch Clearing flags on attachment: 287058 Committed r205054: <http://trac.webkit.org/changeset/205054> All reviewed patches have been landed. Closing bug. |