Bug 161205

Summary: REGRESSION (r204839): [mac-wk1] LayoutTest webgl/max-active-contexts-webglcontextlost-prevent-default.html is a flaky timeout
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: WebGLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, dino, esprehn+autocc, ggaren, graouts, gyuyoung.kim, kondapallykalyan, mark.lam, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161249
Bug Depends on:    
Bug Blocks: 161054    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews115 for mac-yosemite
none
Patch
none
Patch
none
Patch none

Description Ryan Haddad 2016-08-25 13:04:21 PDT 
LayoutTest webgl/max-active-contexts-webglcontextlost-prevent-default.html is a flaky timeout

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2Fmax-active-contexts-webglcontextlost-prevent-default.html
Comment 1 Ryan Haddad 2016-08-25 13:06:04 PDT 
This test has been flaky since 8/23/2016 11:03:06 AM ~r204840
Comment 2 Ryan Haddad 2016-08-25 13:14:13 PDT 
Possibly related? http://trac.webkit.org/changeset/204839
Comment 3 Ryan Haddad 2016-08-26 16:49:42 PDT 
Marked test as flaky on mac-wk1 in http://trac.webkit.org/projects/webkit/changeset/205059
Comment 4 Alexey Proskuryakov 2016-08-31 15:14:13 PDT 
Hmm, no new failures today, so may also be related to bug 161249.
Comment 5 Chris Dumez 2016-09-01 10:45:45 PDT 
I am able to reproduce the flaky time out locally like so:
Tools/Scripts/run-webkit-tests --release -1 --repeat-each=500 webgl/max-active-contexts-webglcontextlost-prevent-default.html

I will investigate to see if this is caused by my change at r204839.
Comment 6 Chris Dumez 2016-09-01 11:44:08 PDT 
Fix on the way.
Comment 7 Chris Dumez 2016-09-01 11:47:20 PDT 
Created attachment 287647 [details]
Patch
Comment 8 Chris Dumez 2016-09-01 11:53:25 PDT 
I am actually still confirming this is caused by r204839. I have just realized I am forgotten to update TestExpectations locally, which is why the test started passing.
Comment 9 Chris Dumez 2016-09-01 12:00:27 PDT 
I have confirmed this is caused by r204839 and I have an idea of what could be happening. I am working on a fix. If it takes to long to figure out, I'll rollout r204839.
Comment 10 Chris Dumez 2016-09-01 12:53:46 PDT 
Created attachment 287659 [details]
Patch
Comment 11 Chris Dumez 2016-09-01 12:55:45 PDT 
Created attachment 287661 [details]
Patch
Comment 12 Chris Dumez 2016-09-01 13:12:24 PDT 
Created attachment 287664 [details]
Patch
Comment 13 Build Bot 2016-09-01 14:13:43 PDT 
Comment on attachment 287664 [details]
Patch

Attachment 287664 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1989154

New failing tests:
webgl/1.0.2/conformance/extensions/oes-texture-float.html
Comment 14 Build Bot 2016-09-01 14:13:48 PDT 
Created attachment 287678 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 15 Chris Dumez 2016-09-01 15:18:32 PDT 
Created attachment 287689 [details]
Patch
Comment 16 Chris Dumez 2016-09-01 15:38:41 PDT 
Created attachment 287694 [details]
Patch
Comment 17 Chris Dumez 2016-09-01 16:21:40 PDT 
Comment on attachment 287694 [details]
Patch

All green. Geoff, is this something you could review? I don't know who else is familiar with isReachableFromOpaqueRoots / visitAdditionalChildren.
Comment 18 Chris Dumez 2016-09-01 16:29:34 PDT 
Created attachment 287701 [details]
Patch
Comment 19 Geoffrey Garen 2016-09-02 11:55:09 PDT 
Comment on attachment 287701 [details]
Patch

r=me
Comment 20 WebKit Commit Bot 2016-09-02 12:16:40 PDT 
Comment on attachment 287701 [details]
Patch

Clearing flags on attachment: 287701

Committed r205360: <http://trac.webkit.org/changeset/205360>
Comment 21 WebKit Commit Bot 2016-09-02 12:16:47 PDT 
All reviewed patches have been landed.  Closing bug.