Bug 161050

Summary: Introduce a MathMLRowElement class for mrow-like elements
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 160543, 161053, 161230, 161232    
Attachments:
Description Flags
Patch
darin: review+
Patch none

Frédéric Wang (:fredw)
Reported 2016-08-22 12:07:50 PDT
Another step for bug 160543.
Attachments
Patch (21.98 KB, patch)
2016-08-22 12:29 PDT, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
Patch (38.84 KB, patch)
2016-08-23 00:55 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-08-22 12:29:35 PDT
Created attachment 286612 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2016-08-22 12:57:57 PDT
Comment on attachment 286612 [details] Patch I noticed that the constructor of RenderMathMLRow (and its derived class) can now take MathMLRowElement (or a derived class) as a parameter.
Darin Adler
Comment 3 2016-08-22 23:45:25 PDT
Comment on attachment 286612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286612&action=review > Source/WebCore/mathml/MathMLRowElement.h:39 > + void childrenChanged(const ChildChange&) final; Seems this could be private instead of protected. > Source/WebCore/mathml/MathMLRowElement.h:42 > + bool acceptsDisplayStyleAttribute() override; > + bool acceptsMathVariantAttribute() override; Seems these could both be final instead of override and private instead of protected.
Frédéric Wang (:fredw)
Comment 4 2016-08-23 00:55:01 PDT
Created attachment 286689 [details] Patch Updated patch that also force renderer constructors to take a MathMLRowElement and make more element classes inherits from MathMLRowElement.
Frédéric Wang (:fredw)
Comment 5 2016-08-23 01:29:56 PDT
Committed r204779: <http://trac.webkit.org/changeset/204779>
Note You need to log in before you can comment on or make changes to this bug.