Bug 160910

Summary:

check-webkit-style does not work with Lambda functions in C++

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, beidson, commit-queue, dbates, glenn, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=125616
https://bugs.webkit.org/show_bug.cgi?id=161247

Attachments:

Description	Flags
Patch	none

Jonathan Bedard

Reported 2016-08-16 14:11:41 PDT

The check-webkit-style script treats lambda functions as regular C++ functions from a style perspective, which is incorrect.

Attachments
Patch (5.21 KB, patch) 2016-08-16 14:31 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2016-08-16 14:31:29 PDT

Created attachment 286204 [details] Patch

Alex Christensen

Comment 2 2016-08-16 16:36:25 PDT

Comment on attachment 286204 [details] Patch hooray!

Brady Eidson

Comment 3 2016-08-16 16:49:30 PDT

Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?

Jonathan Bedard

Comment 4 2016-08-16 17:08:32 PDT

(In reply to comment #3) > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ? Looks like they are addressing the same issue. This change was made in more places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, it's following the same pattern as if, else and while, among others. It also flags cases such as: [var1 , var2], [ & ] and [ ]. https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be interested how it does with the tests in this patch.

Brady Eidson

Comment 5 2016-08-16 17:11:30 PDT

(In reply to comment #4) > (In reply to comment #3) > > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ? > > Looks like they are addressing the same issue. This change was made in more > places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, > it's following the same pattern as if, else and while, among others. > > It also flags cases such as: [var1 , var2], [ & ] and [ ]. > > https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be > interested how it does with the tests in this patch. I didn't really mean is that patch the same as this patch - That patch was long ago abandoned. I meant that this bug is a dupe of that bug.

Jonathan Bedard

Comment 6 2016-08-16 17:14:29 PDT

(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > ... > > > > ... > > I didn't really mean is that patch the same as this patch - That patch was > long ago abandoned. > > I meant that this bug is a dupe of that bug. Yeah, I just looked at the date on that. Somehow I missed it. And yes, this would be a duplicate of that.

WebKit Commit Bot

Comment 7 2016-08-22 09:42:31 PDT

Comment on attachment 286204 [details] Patch Clearing flags on attachment: 286204 Committed r204723: <http://trac.webkit.org/changeset/204723>

WebKit Commit Bot

Comment 8 2016-08-22 09:42:35 PDT

All reviewed patches have been landed. Closing bug.

Jonathan Bedard

Comment 9 2016-08-26 09:13:03 PDT

*** Bug 125616 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.