Bug 160660

Summary: Update API tests in mac/SetDocumentURI.mm after r204247
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, darin, dbates, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160649    
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2016-08-08 09:26:25 PDT
https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/16963/steps/run-api-tests/logs/stdio FAIL WebKit1.SetDocumentURITestNull /Volumes/Data/slave/yosemite-release/build/Tools/TestWebKitAPI/Tests/mac/SetDocumentURI.mm:118 Value of: [document baseURI] Actual: "about:blank" Expected: @"" Which is: "" FAIL WebKit1.SetDocumentURITestString /Volumes/Data/slave/yosemite-release/build/Tools/TestWebKitAPI/Tests/mac/SetDocumentURI.mm:101 Value of: [document baseURI] Actual: "about:blank" Expected: @"" Which is: ""
Attachments
Patch (1.71 KB, patch)
2016-08-08 09:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-08-08 09:27:11 PDT
Tests started failing after http://trac.webkit.org/changeset/204247 changed the baseURI to "about:blank"
Chris Dumez
Comment 2 2016-08-08 09:40:33 PDT
Oh, I'll fix, thanks.
Chris Dumez
Comment 3 2016-08-08 09:43:00 PDT
Created attachment 285568 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-08 10:25:44 PDT
Comment on attachment 285568 [details] Patch Clearing flags on attachment: 285568 Committed r204256: <http://trac.webkit.org/changeset/204256>
WebKit Commit Bot
Comment 5 2016-08-08 10:25:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.