Bug 160498 – http/tests/fetch/fetch-in-worker-crash.html is sometimes crashing

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

crash log is:

STDERR: 3   0x7f367e5d3e24 WebCore::WorkerThreadableLoader::MainThreadBridge::clearClientWrapper()
STDERR: 4   0x7f367e5d3eb4 WebCore::WorkerThreadableLoader::MainThreadBridge::cancel()
STDERR: 5   0x7f367e2f431b WebCore::ScriptExecutionContext::stopActiveDOMObjects()
STDERR: 6   0x7f367eabe15c
STDERR: 7   0x7f367eaba531 WebCore::WorkerRunLoop::Task::performTask(WebCore::WorkerRunLoop const&, WebCore::WorkerGlobalScope*)
STDERR: 8   0x7f367eaba6c9 WebCore::WorkerRunLoop::runCleanupTasks(WebCore::WorkerGlobalScope*)
STDERR: 9   0x7f367eabad97 WebCore::WorkerRunLoop::run(WebCore::WorkerGlobalScope*)
STDERR: 10  0x7f367eabd315 WebCore::WorkerThread::workerThread()

[youenn fablet]

Created attachment 285218 [details]
Patch

[Chris Dumez]

Comment on attachment 285218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285218&action=review

> Source/WebCore/loader/WorkerThreadableLoader.cpp:152
> +    if (m_workerClientWrapper->done())

This seems odd, if we're done, then presumably we already called didFail() / didFinishLoading(), therefore, the code below should have no effect. Do we want something like this instead?
if (m_workerClientWrapper->done()) {
    clearClientWrapper();
    return;
}
// ... the test of your code ...

[youenn fablet]

*** Bug 160510 has been marked as a duplicate of this bug. ***

[youenn fablet]

Created attachment 285241 [details]
Adding missing early return

[Chris Dumez]

Comment on attachment 285241 [details]
Adding missing early return

r=me

[youenn fablet]

It may be that the second promise may resolve before the end of the test, in which case the test might still be flaky.
Let's see what bots will say.

[WebKit Commit Bot]

Comment on attachment 285241 [details]
Adding missing early return

Clearing flags on attachment: 285241

Committed r204085: <http://trac.webkit.org/changeset/204085>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.