Summary: | http/tests/fetch/fetch-in-worker-crash.html is sometimes crashing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, japhet, ryanhaddad | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 151937 | ||||||||
Attachments: |
|
Description
youenn fablet
2016-08-03 04:54:40 PDT
Created attachment 285218 [details]
Patch
Comment on attachment 285218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285218&action=review > Source/WebCore/loader/WorkerThreadableLoader.cpp:152 > + if (m_workerClientWrapper->done()) This seems odd, if we're done, then presumably we already called didFail() / didFinishLoading(), therefore, the code below should have no effect. Do we want something like this instead? if (m_workerClientWrapper->done()) { clearClientWrapper(); return; } // ... the test of your code ... *** Bug 160510 has been marked as a duplicate of this bug. *** Created attachment 285241 [details]
Adding missing early return
Comment on attachment 285241 [details]
Adding missing early return
r=me
It may be that the second promise may resolve before the end of the test, in which case the test might still be flaky. Let's see what bots will say. Comment on attachment 285241 [details] Adding missing early return Clearing flags on attachment: 285241 Committed r204085: <http://trac.webkit.org/changeset/204085> All reviewed patches have been landed. Closing bug. |