Bug 160485

Summary:

Web Inspector: Add placeholder graphs to TimelineOverview while editing

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

157957

Attachments:

Description	Flags
[Image] Network graph w/ four placeholder graphs	none
[Patch] Proposed Fix	none
[Image] UI w/o alternating graph styles	none
[Patch] Proposed Fix	none

Description Matt Baker 2016-08-02 18:22:46 PDT

In order for timeline drag and drop to work (https://bugs.webkit.org/show_bug.cgi?id=157957), each placeholder tree item needs a corresponding placeholder element in the graph container.

Comment 1 Radar WebKit Bug Importer 2016-08-02 18:23:39 PDT

<rdar://problem/27670755>

Comment 2 Matt Baker 2016-08-02 18:27:33 PDT

Created attachment 285178 [details]
[Image] Network graph w/ four placeholder graphs

Comment 3 Matt Baker 2016-08-02 18:34:22 PDT

Created attachment 285180 [details]
[Patch] Proposed Fix

Comment 4 Blaze Burg 2016-08-03 09:53:36 PDT

Comment on attachment 285180 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=285180&action=review

The change looks fine, but I don't understand why it's necessary. Can you please put more "why" into the changelog?

> Source/WebInspectorUI/ChangeLog:16
> +2016-08-02  Matt Baker  <mattbaker@apple.com>

Nit: Double changelog.

Comment 5 Matt Baker 2016-08-03 13:32:42 PDT

Created attachment 285265 [details]
[Image] UI w/o alternating graph styles

Comment 6 Matt Baker 2016-08-03 13:35:16 PDT

This patch does two things:

1) allows the alternating graph styles to be shown for the inactive instruments
2) when a instrument is dragged/reordered the tree item and graph move together

Comment 7 Matt Baker 2016-08-03 13:38:40 PDT

Created attachment 285266 [details]
[Patch] Proposed Fix

Comment 8 Blaze Burg 2016-08-04 10:29:05 PDT

Comment on attachment 285266 [details]
[Patch] Proposed Fix

r=me

Comment 9 WebKit Commit Bot 2016-08-04 10:50:00 PDT

Comment on attachment 285266 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 285266

Committed r204125: <http://trac.webkit.org/changeset/204125>

Comment 10 WebKit Commit Bot 2016-08-04 10:50:04 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 Joseph Pecoraro 2016-08-10 23:34:37 PDT

Heck yes! Nice, I've been wanting this for a while!