Bug 160474

Summary: Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=160478
Attachments:
Description Flags
Patch simon.fraser: review+

Dean Jackson
Reported 2016-08-02 16:07:11 PDT
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569
Attachments
Patch (45.78 KB, patch)
2016-08-02 16:15 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-02 16:09:36 PDT
<rdar://problem/27668170>
Dean Jackson
Comment 2 2016-08-02 16:09:50 PDT
These fixes were fine, but they caused a regression on medium.com, and were reverted in http://trac.webkit.org/r203380
Radar WebKit Bug Importer
Comment 3 2016-08-02 16:10:05 PDT
<rdar://problem/27668184>
Dean Jackson
Comment 4 2016-08-02 16:15:13 PDT
Created attachment 285156 [details] Patch
Simon Fraser (smfr)
Comment 5 2016-08-02 16:16:54 PDT
Comment on attachment 285156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285156&action=review > Source/WebCore/ChangeLog:13 > + Now that we've branched, revert the reversion (which itself > + was a reversion), and then fix the actual bug. Please make it clear that this change does not fix the bug.
Dean Jackson
Comment 6 2016-08-02 16:45:01 PDT
Committed r204052: <http://trac.webkit.org/changeset/204052>
mitz
Comment 7 2016-08-02 16:57:19 PDT
I don’t understand why we’re reintroducing these breaking changes. Nothing has changed since they were backed out. Seems like they should only be reintroduced once there is a plan to fix them.
Note You need to log in before you can comment on or make changes to this bug.