Bug 160332

Summary: ANGLE: Fix global constructors and exit-time destructors
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: ANGLEAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, graouts, kondapallykalyan, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=160333
https://bugs.chromium.org/p/angleproject/issues/detail?id=1459
Bug Depends on:    
Bug Blocks: 160302    
Attachments:
Description Flags
Patch v1 darin: review+, darin: commit-queue-

David Kilzer (:ddkilzer)
Reported 2016-07-28 22:09:35 PDT
The -Wglobal-constructors, -Wexit-time-destructors clang warning switches had never been added to the ANGLE project (nor had the check-for-global-initializers, check-for-exit-time-destructors scripts ever been added as build phase scripts to the Xcode project), so there were a number of global constructors and exit-time destructors to clean up.
Attachments
Patch v1 (142.91 KB, patch)
2016-07-28 22:30 PDT, David Kilzer (:ddkilzer) 		darin: review+
darin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-07-28 22:30:03 PDT
Created attachment 284847 [details] Patch v1
WebKit Commit Bot
Comment 2 2016-07-28 22:31:06 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
WebKit Commit Bot
Comment 3 2016-07-28 22:31:15 PDT
Attachment 284847 [details] did not pass style-queue: ERROR: Source/ThirdParty/ANGLE/src/compiler/translator/ShaderLang.cpp:374: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/ThirdParty/ANGLE/src/common/mathutil.cpp:34: g_sharedexp_max is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/ThirdParty/ANGLE/src/common/mathutil.cpp:36: sharedexp_max is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/ThirdParty/ANGLE/src/common/mathutil.cpp:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/ANGLE/src/common/mathutil.cpp:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/ANGLE/src/common/mathutil.cpp:44: red_c is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/ThirdParty/ANGLE/src/common/mathutil.cpp:45: green_c is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/ThirdParty/ANGLE/src/common/mathutil.cpp:46: blue_c is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:405: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:406: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:407: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:408: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:409: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:410: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:412: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:413: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:414: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:417: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:418: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:420: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:421: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:422: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:427: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:428: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:433: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:434: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:439: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:440: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:446: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:447: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:448: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:457: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:458: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:459: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:460: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:467: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:468: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:469: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:474: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:475: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:476: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:478: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:480: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:493: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:494: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:495: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:496: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:532: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:533: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:534: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:535: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:536: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:538: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:539: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:547: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:548: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:550: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:551: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:552: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:553: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:554: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp:747: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:55: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:56: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:57: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:58: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:59: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:60: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:61: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:62: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:63: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:64: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:65: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:66: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:67: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:68: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:69: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:70: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:71: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:72: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:73: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:74: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:75: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:76: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:77: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:78: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:79: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:80: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:81: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:82: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:83: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:84: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:85: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:86: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:87: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:88: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:89: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:90: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:91: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:92: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:93: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:94: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:95: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:96: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:97: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:98: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:99: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:100: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:101: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:102: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:103: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:104: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:105: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:106: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:107: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:108: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:109: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:110: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:111: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:112: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:113: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:114: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:115: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:116: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:117: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:118: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:119: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:120: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:121: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:124: Extra space before ) [whitespace/parens] [2] ERROR: Source/ ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:125: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:126: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:127: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:128: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:129: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:130: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:131: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:132: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:133: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:134: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:135: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:136: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:137: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:138: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:139: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:140: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:141: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:142: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:145: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:146: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:147: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:148: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:149: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:153: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:154: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:157: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:158: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:159: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:160: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:161: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:164: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:165: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:166: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:167: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:168: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:169: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:172: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:177: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:178: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:179: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:180: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:181: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:182: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:183: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:184: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:185: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:186: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:187: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:188: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:191: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:193: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:195: Extra space before ) [whitespace/parens] [2] ERROR: Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp:198: Extra space before ) [whitespace/parens] [2] Total errors found: 187 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 4 2016-07-28 22:32:49 PDT
(In reply to comment #3) > Attachment 284847 [details] did not pass style-queue: > > [...] > Total errors found: 187 in 12 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. NOTE TO SELF: Disable check-webkit-style for ANGLE since we keep the upstream formatting to make merging easier.
David Kilzer (:ddkilzer)
Comment 5 2016-07-28 22:40:41 PDT
(In reply to comment #4) > NOTE TO SELF: Disable check-webkit-style for ANGLE since we keep the > upstream formatting to make merging easier. Bug 160333: Ignore most check-webkit-style checks for ANGLE project
David Kilzer (:ddkilzer)
Comment 6 2016-07-28 23:01:19 PDT
Filed this upstream bug for the ANGLE project: <https://bugs.chromium.org/p/angleproject/issues/detail?id=1459>
Darin Adler
Comment 7 2016-07-29 12:12:03 PDT
Comment on attachment 284847 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=284847&action=review Please consider doing the smaller patch using references. Will be much easier to merge and such. > Source/ThirdParty/ANGLE/src/common/angleutils.cpp:39 > + static std::vector<char>* buffer = new std::vector<char>(512); Could use references instead of pointers for these, which would make the patch considerably smaller! static std::vector<char>& buffer = *new std::vector<char>(512); On a separate note, the Noncopyable idiom is more efficient because it avoids adding additional heap allocation and a level of indirection. > Source/ThirdParty/ANGLE/src/common/angleutils.h:119 > + static std::set<std::string>* strings = new std::set<std::string>(); No need for the () at the end of expressions like this. If this was in WebKit proper I would also have suggested using auto to avoid repeating the type twice.
David Kilzer (:ddkilzer)
Comment 8 2016-07-29 20:17:30 PDT
Comment on attachment 284847 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=284847&action=review >> Source/ThirdParty/ANGLE/src/common/angleutils.cpp:39 >> + static std::vector<char>* buffer = new std::vector<char>(512); > > Could use references instead of pointers for these, which would make the patch considerably smaller! > > static std::vector<char>& buffer = *new std::vector<char>(512); > > On a separate note, the Noncopyable idiom is more efficient because it avoids adding additional heap allocation and a level of indirection. Wow. Not sure how I missed that. I will change the patch to use references (instead of pointers) before landing! >> Source/ThirdParty/ANGLE/src/common/angleutils.h:119 >> + static std::set<std::string>* strings = new std::set<std::string>(); > > No need for the () at the end of expressions like this. If this was in WebKit proper I would also have suggested using auto to avoid repeating the type twice. I will change the patch to remove () and use 'auto' since the ANGLE project already has many uses of 'auto'.
David Kilzer (:ddkilzer)
Comment 9 2016-07-29 20:25:02 PDT
Committed r203938: <http://trac.webkit.org/changeset/203938>
Note You need to log in before you can comment on or make changes to this bug.