Bug 160333 - Ignore most check-webkit-style checks for ANGLE project
Summary: Ignore most check-webkit-style checks for ANGLE project
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-28 22:39 PDT by David Kilzer (:ddkilzer)
Modified: 2016-07-29 18:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (1.25 KB, patch)
2016-07-28 22:46 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-07-28 22:39:40 PDT 
The ANGLE project source does not match WebKit style.  Instead, we preserve it so that merging upstream changes is easier.

For this reason, we should relax what check-webkit-style accepts to avoid the horror of Bug 160332 Comment #3.
Comment 1 David Kilzer (:ddkilzer) 2016-07-28 22:46:00 PDT 
Created attachment 284848 [details]
Patch v1
Comment 2 Aakash Jain 2016-07-29 07:02:24 PDT 
unofficial r+
Comment 3 Daniel Bates 2016-07-29 18:05:39 PDT 
Comment on attachment 284848 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=284848&action=review

> Tools/ChangeLog:11
> +        - No carriage returns (DOS line endings).

Eww :(
Comment 4 WebKit Commit Bot 2016-07-29 18:26:46 PDT 
Comment on attachment 284848 [details]
Patch v1

Clearing flags on attachment: 284848

Committed r203936: <http://trac.webkit.org/changeset/203936>
Comment 5 WebKit Commit Bot 2016-07-29 18:26:50 PDT 
All reviewed patches have been landed.  Closing bug.