Summary: | REGRESSION(r203537): It made many tests crash on ARMv7 with ARM instruction set | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Critical | CC: | benjamin, ossy, saam |
Priority: | P1 | ||
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=159720 | ||
Bug Depends on: | |||
Bug Blocks: | 108645, 159649 |
Description
Csaba Osztrogonác
2016-07-25 02:13:57 PDT
I can confirm that this bug and bug159720 have the same root. The problem is that "auto jump = jit.jump();" allocates a constant on the constant pool which makes linkBuffer ctor not to allocate. But the question is still open, can we disable IC generating on ARM traditional until we can find the proper fix? Because now it is completely broken and there are 2700 crashing stress tests. *** This bug has been marked as a duplicate of bug 159720 *** (In reply to comment #0) > Can't we disable this new feature somehow similar to > https://trac.webkit.org/changeset/203272 ? ARM assembler is completely broken more than a month ago because of this IC refactoring work. It would be great to get an answer if we can workaround it or not. You can make MathIC generateInline always return false before generating any code. This will make the resulting code quite slow though. It will lead to a C call for every JS add. (In reply to comment #3) > You can make MathIC generateInline always return false before > generating any code. This will make the resulting code quite > slow though. It will lead to a C call for every JS add. Uploaded a patch to bug159759 to disable it. |