Bug 159990

Summary: REGRESSION(r148588): ews classes might get garbage collected
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, glenn, lforschler, rniwa
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=114558
https://bugs.webkit.org/show_bug.cgi?id=160001
https://bugs.webkit.org/show_bug.cgi?id=159539
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2016-07-20 15:54:28 PDT
sometimes running webkit-patch command for ews queues fails with below error. buildbot$ ./Tools/Scripts/webkit-patch ios-ews --bot-id=bot110 --exit-after-iteration 1 Usage: webkit-patch [options] COMMAND [ARGS] webkit-patch: error: no such option: --exit-after-iteration It happens because webkit-patch sometimes do not know about ews classes. This happens because AbstractEarlyWarningSystem.load_ews_classes() is called in webkitpy/tool/commands/__init__.py, but the result is not stored in a variable and it might get garbage collected.
Attachments
Proposed patch (1.14 KB, patch)
2016-07-20 16:06 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2016-07-20 16:05:44 PDT
This issue got exposed by a recent commit <http://trac.webkit.org/r203386>, and we did a temporary fix <http://trac.webkit.org/r203417>.
Aakash Jain
Comment 2 2016-07-20 16:06:07 PDT
Created attachment 284162 [details] Proposed patch
WebKit Commit Bot
Comment 3 2016-07-20 16:29:20 PDT
Comment on attachment 284162 [details] Proposed patch Clearing flags on attachment: 284162 Committed r203479: <http://trac.webkit.org/changeset/203479>
WebKit Commit Bot
Comment 4 2016-07-20 16:29:25 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2016-07-20 17:08:56 PDT
Comment on attachment 284162 [details] Proposed patch Aakash, could you please revert the temporary fix?
Aakash Jain
Comment 6 2016-07-20 17:28:23 PDT
sure, reverting it in https://bugs.webkit.org/show_bug.cgi?id=160001
Note You need to log in before you can comment on or make changes to this bug.