Bug 159254

Summary:

WebRTC: Implement MediaEndpointPeerConnection::setConfiguration()

Product:

WebKit

Reporter:

Adam Bergkvist <adam.bergkvist>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

143211

Attachments:

Description	Flags
Proposed patch	eric.carlson: review+
Updated patch (for landing)	buildbot: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch for landing	none

Description Adam Bergkvist 2016-06-29 01:17:21 PDT

MediaEndpointPeerConnection::setConfiguration() is the MediaEndpointPeerConnection implementation of RTCPeerConnection.steConfiguration() [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-setconfiguration

Comment 1 Adam Bergkvist 2016-06-29 01:45:50 PDT

Created attachment 282332 [details]
Proposed patch

Comment 2 Eric Carlson 2016-06-29 08:23:18 PDT

Comment on attachment 282332 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282332&action=review

> Source/WebCore/platform/mediastream/PeerConnectionStates.h:32
> +#ifndef PeerConnectionStates_h
> +#define PeerConnectionStates_h

Nit: this can use "#pragma once"

Comment 3 Adam Bergkvist 2016-06-29 10:29:15 PDT

Created attachment 282356 [details]
Updated patch (for landing)

Comment 4 Adam Bergkvist 2016-06-29 10:29:40 PDT

(In reply to comment #2)

Thanks for reviewing

> Comment on attachment 282332 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282332&action=review
> 
> > Source/WebCore/platform/mediastream/PeerConnectionStates.h:32
> > +#ifndef PeerConnectionStates_h
> > +#define PeerConnectionStates_h
> 
> Nit: this can use "#pragma once"

Fixed

Comment 5 Build Bot 2016-06-29 11:09:18 PDT

Comment on attachment 282356 [details]
Updated patch (for landing)

Attachment 282356 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1595383

New failing tests:
animations/multiple-backgrounds.html

Comment 6 Build Bot 2016-06-29 11:09:20 PDT

Created attachment 282361 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

Comment 7 Adam Bergkvist 2016-06-29 13:15:20 PDT

Created attachment 282367 [details]
Patch for landing

Comment 8 WebKit Commit Bot 2016-06-29 21:49:50 PDT

Comment on attachment 282367 [details]
Patch for landing

Clearing flags on attachment: 282367

Committed r202671: <http://trac.webkit.org/changeset/202671>

Comment 9 WebKit Commit Bot 2016-06-29 21:49:53 PDT

All reviewed patches have been landed.  Closing bug.