Bug 159104

Summary:

REGRESSION: Weak symbol warning when linking TestWebKitAPI

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Tools / Tests

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, lforschler, mitz

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

158625

Bug Blocks:

Attachments:

Description	Flags
the patch	mark.lam: review+
the patch	mitz: review+

Filip Pizlo

Reported 2016-06-24 15:44:55 PDT

Patch forthcoming.

Attachments
the patch (1.59 KB, patch) 2016-06-24 15:45 PDT, Filip Pizlo	mark.lam: review+	Details Formatted Diff Diff
the patch (2.68 KB, patch) 2016-06-25 12:03 PDT, Filip Pizlo	mitz: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-06-24 15:45:51 PDT

Created attachment 282021 [details] the patch

Mark Lam

Comment 2 2016-06-24 16:47:31 PDT

Comment on attachment 282021 [details] the patch rs=me

Filip Pizlo

Comment 3 2016-06-24 16:49:55 PDT

Landed in https://trac.webkit.org/changeset/202461

mitz

Comment 4 2016-06-24 16:57:32 PDT

Comment on attachment 282021 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=282021&action=review > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > + OTHER_CPLUSPLUSFLAGS = ( > + "$(inherited)", > + "-ftemplate-depth=256", > + "-fvisibility=hidden", > + ); Build settings should go into TestWTFLibrary.xcconfig, not into the project file… > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > + OTHER_CPLUSPLUSFLAGS = ( > + "$(inherited)", > + "-ftemplate-depth=256", > + "-fvisibility=hidden", > + ); …so they don’t have to be repeated like this.

Filip Pizlo

Comment 5 2016-06-24 16:58:23 PDT

(In reply to comment #4) > Comment on attachment 282021 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282021&action=review > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > > + OTHER_CPLUSPLUSFLAGS = ( > > + "$(inherited)", > > + "-ftemplate-depth=256", > > + "-fvisibility=hidden", > > + ); > > Build settings should go into TestWTFLibrary.xcconfig, not into the project > file… > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > > + OTHER_CPLUSPLUSFLAGS = ( > > + "$(inherited)", > > + "-ftemplate-depth=256", > > + "-fvisibility=hidden", > > + ); > > …so they don’t have to be repeated like this. You're right. I should have remembered this.

Filip Pizlo

Comment 6 2016-06-24 17:01:43 PDT

(In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 282021 [details] > > the patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=282021&action=review > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > > > + OTHER_CPLUSPLUSFLAGS = ( > > > + "$(inherited)", > > > + "-ftemplate-depth=256", > > > + "-fvisibility=hidden", > > > + ); > > > > Build settings should go into TestWTFLibrary.xcconfig, not into the project > > file… > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > > > + OTHER_CPLUSPLUSFLAGS = ( > > > + "$(inherited)", > > > + "-ftemplate-depth=256", > > > + "-fvisibility=hidden", > > > + ); > > > > …so they don’t have to be repeated like this. > > You're right. I should have remembered this. Actually, it appears that everywhere else, we set this option in the project.pbxproj. But we do it differently. I'll upload a patch.

Filip Pizlo

Comment 7 2016-06-25 11:51:30 PDT

(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Comment on attachment 282021 [details] > > > the patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=282021&action=review > > > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339 > > > > + OTHER_CPLUSPLUSFLAGS = ( > > > > + "$(inherited)", > > > > + "-ftemplate-depth=256", > > > > + "-fvisibility=hidden", > > > > + ); > > > > > > Build settings should go into TestWTFLibrary.xcconfig, not into the project > > > file… > > > > > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351 > > > > + OTHER_CPLUSPLUSFLAGS = ( > > > > + "$(inherited)", > > > > + "-ftemplate-depth=256", > > > > + "-fvisibility=hidden", > > > > + ); > > > > > > …so they don’t have to be repeated like this. > > > > You're right. I should have remembered this. > > Actually, it appears that everywhere else, we set this option in the > project.pbxproj. But we do it differently. I'll upload a patch. Wrong again! The xcconfig option is: GCC_SYMBOLS_PRIVATE_EXTERN = YES;

Filip Pizlo

Comment 8 2016-06-25 12:03:57 PDT

Created attachment 282081 [details] the patch

Filip Pizlo

Comment 9 2016-06-25 12:08:09 PDT

Landed in https://trac.webkit.org/changeset/202469

Note You need to log in before you can comment on or make changes to this bug.