Bug 159077

Summary: [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ryanhaddad, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159337    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Simon Fraser (smfr) 2016-06-23 16:38:52 PDT
[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
Comment 1 Simon Fraser (smfr) 2016-06-23 16:41:42 PDT
Created attachment 281941 [details]
Patch
Comment 2 Tim Horton 2016-06-23 16:44:36 PDT
Comment on attachment 281941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281941&action=review

> Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:172
> +EXTERN_C uint8_t *CARenderServerGetBufferData(CARenderServerBufferRef);

star's on the wrong side :P

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:211
> +    int bufferWidth = ceil(bufferSize.width * deviceScaleFactor);

I could see someone making use of bufferSize and it being wrong here.

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:220
> +    CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, [m_view layer].context.contextId, reinterpret_cast<uint64_t>(m_view.layer), buffer, 0, 0, &transform);

Dots
Comment 4 Simon Fraser (smfr) 2016-06-23 20:32:22 PDT
Have to disable this in WTR because we have some synchronization issues (the "wait for the web process" is broken).
Comment 5 Simon Fraser (smfr) 2016-06-27 17:44:35 PDT
Created attachment 282195 [details]
Patch
Comment 6 WebKit Commit Bot 2016-06-27 17:45:53 PDT
Attachment 282195 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2891:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Simon Fraser (smfr) 2016-06-27 18:46:06 PDT
https://trac.webkit.org/r202532
Comment 8 Simon Fraser (smfr) 2016-06-27 18:46:17 PDT
I'll garden the iOS tests.
Comment 9 Simon Fraser (smfr) 2016-06-27 22:56:56 PDT
Followup fix in r202540.