Bug 159077

Summary:

[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, ryanhaddad, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

159337

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+

Simon Fraser (smfr)

Reported 2016-06-23 16:38:52 PDT

[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting

Attachments
Patch (22.66 KB, patch) 2016-06-23 16:41 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (9.59 KB, patch) 2016-06-27 17:44 PDT, Simon Fraser (smfr)	thorton: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2016-06-23 16:41:42 PDT

Created attachment 281941 [details] Patch

Tim Horton

Comment 2 2016-06-23 16:44:36 PDT

Comment on attachment 281941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281941&action=review > Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:172 > +EXTERN_C uint8_t *CARenderServerGetBufferData(CARenderServerBufferRef); star's on the wrong side :P > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:211 > + int bufferWidth = ceil(bufferSize.width * deviceScaleFactor); I could see someone making use of bufferSize and it being wrong here. > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:220 > + CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, [m_view layer].context.contextId, reinterpret_cast<uint64_t>(m_view.layer), buffer, 0, 0, &transform); Dots

Ryan Haddad

Comment 3 2016-06-23 17:55:46 PDT

The follow up change, https://trac.webkit.org/r202405, fixed the Mac builds, but the iOS and Windows builds still appear to be broken: https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/7381 https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/78640

Simon Fraser (smfr)

Comment 4 2016-06-23 20:32:22 PDT

Have to disable this in WTR because we have some synchronization issues (the "wait for the web process" is broken).

Simon Fraser (smfr)

Comment 5 2016-06-27 17:44:35 PDT

Created attachment 282195 [details] Patch

WebKit Commit Bot

Comment 6 2016-06-27 17:45:53 PDT

Attachment 282195 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2891: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 7 2016-06-27 18:46:06 PDT

https://trac.webkit.org/r202532

Simon Fraser (smfr)

Comment 8 2016-06-27 18:46:17 PDT

I'll garden the iOS tests.

Simon Fraser (smfr)

Comment 9 2016-06-27 22:56:56 PDT

Followup fix in r202540.

Note You need to log in before you can comment on or make changes to this bug.