Summary: | [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, ryanhaddad, simon.fraser, thorton | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 159337 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2016-06-23 16:38:52 PDT
Created attachment 281941 [details]
Patch
Comment on attachment 281941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281941&action=review > Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:172 > +EXTERN_C uint8_t *CARenderServerGetBufferData(CARenderServerBufferRef); star's on the wrong side :P > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:211 > + int bufferWidth = ceil(bufferSize.width * deviceScaleFactor); I could see someone making use of bufferSize and it being wrong here. > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:220 > + CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, [m_view layer].context.contextId, reinterpret_cast<uint64_t>(m_view.layer), buffer, 0, 0, &transform); Dots The follow up change, https://trac.webkit.org/r202405, fixed the Mac builds, but the iOS and Windows builds still appear to be broken: https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/7381 https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/78640 Have to disable this in WTR because we have some synchronization issues (the "wait for the web process" is broken). Created attachment 282195 [details]
Patch
Attachment 282195 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2891: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I'll garden the iOS tests. |