Bug 159008

Summary:

Fix style issues in webkitpy/tool

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dbates, glenn, lforschler

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=159019

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none
Updated patch	none
Another patch	dbates: review-, dbates: commit-queue-

Aakash Jain

Reported 2016-06-21 19:17:51 PDT

Running "./Tools/Scripts/check-webkit-style Tools/Script/webkitpy" reports a lot of issues. Although not a high priority, but we should fix these issues as much as possible. It would help maintain the formatting style and quality. Sometimes these issues are encountered while we are making changes in similar portion of code and run check-webkit-style. At that time, it might be confusing whether the formatting issues were pre-existing or introduced by us.

Attachments
Proposed patch (66.74 KB, patch) 2016-06-21 19:26 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed patch (66.18 KB, patch) 2016-06-21 19:27 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (66.00 KB, patch) 2016-06-21 19:37 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Another patch (71.86 KB, patch) 2016-06-21 22:42 PDT, Aakash Jain	dbates: review- dbates: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2016-06-21 19:26:09 PDT

Created attachment 281804 [details] Proposed patch This patch fixes the formatting issues in webkitpy/tool directory. examples of error reported by check-webkit-style: ERROR: Tools/Scripts/webkitpy/tool/steps/metastep.py:35: expected 1 blank line, found 0 [pep8/E301] [5] ERROR: Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:35: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:175: too many blank lines (2) [pep8/E303] [5] ERROR: Tools/Scripts/webkitpy/tool/steps/metastep.py:54: indentation is not a multiple of four [pep8/E111] [5] ERROR: Tools/Scripts/webkitpy/tool/steps/update.py:16: trailing whitespace [pep8/W291] [5]

Aakash Jain

Comment 2 2016-06-21 19:27:56 PDT

Created attachment 281805 [details] Proposed patch

WebKit Commit Bot

Comment 3 2016-06-21 19:30:42 PDT

Attachment 281805 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:131: no spaces around keyword / parameter equals [pep8/E251] [5] ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:132: no spaces around keyword / parameter equals [pep8/E251] [5] Total errors found: 2 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Aakash Jain

Comment 4 2016-06-21 19:37:44 PDT

Created attachment 281806 [details] Updated patch

WebKit Commit Bot

Comment 5 2016-06-21 20:34:16 PDT

Comment on attachment 281806 [details] Updated patch Clearing flags on attachment: 281806 Committed r202319: <http://trac.webkit.org/changeset/202319>

WebKit Commit Bot

Comment 6 2016-06-21 20:34:20 PDT

All reviewed patches have been landed. Closing bug.

Aakash Jain

Comment 7 2016-06-21 22:42:50 PDT

Created attachment 281817 [details] Another patch This patch fixes the formatting issues in webkitpy directory.

Daniel Bates

Comment 8 2016-06-21 22:56:35 PDT

Comment on attachment 281817 [details] Another patch Please file a new bug with this patch. In general we prefer one patch per bug because it keeps the bug focused and serves as a venue for discussion about the patch.

Note You need to log in before you can comment on or make changes to this bug.