Bug 158834

Summary: The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: BindingsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143211, 158832    
Attachments:
Description Flags
Patch none

Adam Bergkvist
Reported 2016-06-16 05:47:05 PDT
For example: interface RTCPeerConnection : EventTarget
Attachments
Patch (3.29 KB, patch)
2016-06-16 06:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-06-16 06:06:54 PDT
Created attachment 281451 [details] Patch
youenn fablet
Comment 2 2016-06-16 06:07:55 PDT
(In reply to comment #1) > Created attachment 281451 [details] > Patch Adam, can you check whether that patch is working for you?
Adam Bergkvist
Comment 3 2016-06-16 08:48:28 PDT
The test fast/mediastream/RTCRtpSender-replaceTrack.html seem to crash with this change applied. Haven't looked into the cause yet.
Adam Bergkvist
Comment 4 2016-06-17 00:18:35 PDT
(In reply to comment #3) > The test fast/mediastream/RTCRtpSender-replaceTrack.html seem to crash with > this change applied. Haven't looked into the cause yet. Don't mind the above comment. The patch works for me.
Adam Bergkvist
Comment 5 2016-06-18 06:40:42 PDT
youenn, are you planning to update this patch any further or can we commit it? Many thanks for the fix btw :)
youenn fablet
Comment 6 2016-06-18 08:18:06 PDT
Sure, I cannot follow the CQ right now, but will do tomorrow or Monday. Feel free to CQ+ it in the meantime if you prefer
WebKit Commit Bot
Comment 7 2016-06-19 10:51:59 PDT
Comment on attachment 281451 [details] Patch Clearing flags on attachment: 281451 Committed r202211: <http://trac.webkit.org/changeset/202211>
WebKit Commit Bot
Comment 8 2016-06-19 10:52:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.