Bug 158750 – [mac-wk1 debug] LayoutTest userscripts/window-onerror-for-isolated-world-3.html is flaky

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest userscripts/window-onerror-for-isolated-world-3.html is flaky

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/5940>

<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=userscripts%2Fwindow-onerror-for-isolated-world-3.html>

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-actual.txt
@@ -8,12 +8,11 @@
 Main world error event listener: [object Window] at undefined:0:0 null
 
 Main World
+Isolated World
 Main world window.onerror: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world)
 Main world error event listener: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world)
 Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window]
 Main world error event listener: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window]
-
-Isolated World
 Main world window.onerror: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script)
 Main world error event listener: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script)
 Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:11:27 null

[Joseph Pecoraro]

Let me bump up the timeouts just a tad.

[Ryan Haddad]

Created attachment 281275 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 281275 [details]
Patch

r=me!

[Ryan Haddad]

Comment on attachment 281275 [details]
Patch

Clearing flags on attachment: 281275

Committed r202061: <http://trac.webkit.org/changeset/202061>

[Ryan Haddad]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Is there any way to avoid having timeouts in the normal execution path? It is normal for a regression test to stall for a couple seconds, so doubling a timeout is not a reliable fix.

[Joseph Pecoraro]

Yes, it could be possible with more hardcoding of expected messages.

  Expect 4 messages => advance()
  Expect 4 messages => advance()
  Expect 4 messages => advance() => end