Bug 158738

Summary: Enabling Shadow DOM for all platforms
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Romain Bellessort
Reported 2016-06-14 08:06:26 PDT
Following https://bugs.webkit.org/show_bug.cgi?id=158686, it seems that Shadow DOM can be enabled on all platforms and that corresponding build flag can be removed (a runtime flag is available).
Attachments
Patch (110.33 KB, patch)
2016-06-14 10:00 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Patch (110.39 KB, patch)
2016-06-15 06:24 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-06-14 10:00:50 PDT
Created attachment 281264 [details] Patch
WebKit Commit Bot
Comment 2 2016-06-15 01:11:57 PDT
Comment on attachment 281264 [details] Patch Rejecting attachment 281264 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 281264, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: tching file Source/cmake/tools/vsprops/FeatureDefines.props patching file Source/cmake/tools/vsprops/FeatureDefinesCairo.props patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitperl/FeatureList.pm patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig patching file ChangeLog Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1505932
Romain Bellessort
Comment 3 2016-06-15 06:24:04 PDT
Created attachment 281352 [details] Patch
Romain Bellessort
Comment 4 2016-06-15 06:29:05 PDT
Comment on attachment 281352 [details] Patch Same patch after a rebase
WebKit Commit Bot
Comment 5 2016-06-15 08:20:42 PDT
Comment on attachment 281352 [details] Patch Clearing flags on attachment: 281352 Committed r202091: <http://trac.webkit.org/changeset/202091>
WebKit Commit Bot
Comment 6 2016-06-15 08:20:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.