Bug 158688

Summary: WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack()
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143211    
Attachments:
Description Flags
Proposed patch
eric.carlson: review+
Patch for landing none

Description Adam Bergkvist 2016-06-13 04:43:32 PDT
A call to RTCRtpSender.replaceTrack() [1] eventually ends up in MediaEndpointPeerConnection::replaceTrack().

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcrtpsender-replacetrack
Comment 1 Adam Bergkvist 2016-06-13 04:58:37 PDT
Created attachment 281166 [details]
Proposed patch
Comment 2 Eric Carlson 2016-06-13 08:08:51 PDT
Comment on attachment 281166 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281166&action=review

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:634
> +    const String& mid = transceiver->mid();

Is it worth ASSERTing transceiver here?
Comment 3 Adam Bergkvist 2016-06-13 12:18:14 PDT
(In reply to comment #2)
> Comment on attachment 281166 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281166&action=review
> 
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:634
> > +    const String& mid = transceiver->mid();
> 
> Is it worth ASSERTing transceiver here?

We can do that to emphasize that it should always be found or something is broken.
Comment 4 Adam Bergkvist 2016-06-13 14:35:02 PDT
Created attachment 281203 [details]
Patch for landing
Comment 5 Adam Bergkvist 2016-06-13 22:39:57 PDT
Comment on attachment 281203 [details]
Patch for landing

Thanks for reviewing Eric!
Comment 6 WebKit Commit Bot 2016-06-13 23:02:53 PDT
Comment on attachment 281203 [details]
Patch for landing

Clearing flags on attachment: 281203

Committed r202026: <http://trac.webkit.org/changeset/202026>