Bug 158566

Summary: WebRTC: Implement MediaEndpointPeerConnection::createAnswer()
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143211    
Attachments:
Description Flags
Proposed patch
none
Updated patch
eric.carlson: review+
Patch for landing none

Description Adam Bergkvist 2016-06-09 07:45:45 PDT
Add the MediaEndpointPeerConnection implementation of RTCPeerConnection.createAnswer [1]. createAnswer() creats a 'reply' to an remote offer set with setRemoteDescription(), completes the offer/answer dialog and brings the RTCPeerConnection back to the 'stable' signaling state.
Comment 1 Adam Bergkvist 2016-06-09 08:04:11 PDT
Created attachment 280921 [details]
Proposed patch
Comment 2 Adam Bergkvist 2016-06-09 08:44:56 PDT
Created attachment 280923 [details]
Updated patch

Skip test on mac port
Comment 3 Eric Carlson 2016-06-09 11:06:28 PDT
Comment on attachment 280923 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280923&action=review

> Source/WebCore/ChangeLog:9
> +        createAnswer() creats a 'reply' to an remote offer set with setRemoteDescription(),

Nit: "creats" -> "creates"
Comment 4 Adam Bergkvist 2016-06-09 22:29:39 PDT
Created attachment 280996 [details]
Patch for landing

Fixed change log typo. Thanks for reviewing Eric.
Comment 5 WebKit Commit Bot 2016-06-10 02:13:36 PDT
Comment on attachment 280996 [details]
Patch for landing

Clearing flags on attachment: 280996

Committed r201920: <http://trac.webkit.org/changeset/201920>