Bug 158173
| Summary: | Clean up all C++ lambdas passed to methods other than callOnMainThread | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cdumez |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=158172 https://bugs.webkit.org/show_bug.cgi?id=158166 |
||
| Bug Depends on: | 158185, 158187, 158196 | ||
| Bug Blocks: | |||
Brady Eidson
Clean up all C++ lambdas passed to dispatch() methods
Now that we have C++14 we can make sure we don't do unnecessary copies of captured variables, as well as initialize things like protectors inside of the capture list.
By going through all of them we can probably also fix some thread safety issues.
I plan to grep through all of Source using:
grep -rn '\[.\+\]\s*\((.*)\)\?\s*{\s*$' .
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brady Eidson
I meant:
grep -rn '\[.\+\]\s*\((.*)\)\?\s*{\s*$' . | grep -v callOnMainThread
Because I don't want to conflict with https://bugs.webkit.org/show_bug.cgi?id=158166