Bug 158036

Summary: We can cache lookups to JSScope::abstractResolve inside CodeBlock::finishCreation
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: REOPENED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 158238    
Bug Blocks:    
Attachments:
Description Flags
patch
ggaren: review+
patch for landing none

Saam Barati
Reported 2016-05-24 12:18:48 PDT
...
Attachments
patch (7.40 KB, patch)
2016-05-24 13:22 PDT, Saam Barati 		ggaren: review+
DetailsFormatted DiffDiff
patch for landing (7.33 KB, patch)
2016-05-24 13:40 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-05-24 13:22:26 PDT
Created attachment 279697 [details] patch
Geoffrey Garen
Comment 2 2016-05-24 13:28:56 PDT
Comment on attachment 279697 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=279697&action=review r=me > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1871 > + bool isEmptyValue() const { return m_depth == std::numeric_limits<size_t>::max(); } We usually call this isNull(). Can we use nullptr in m_impl as null instead? That's a clearer null value.
Saam Barati
Comment 3 2016-05-24 13:30:57 PDT
Comment on attachment 279697 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=279697&action=review >> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1871 >> + bool isEmptyValue() const { return m_depth == std::numeric_limits<size_t>::max(); } > > We usually call this isNull(). > > Can we use nullptr in m_impl as null instead? That's a clearer null value. Will do.
Saam Barati
Comment 4 2016-05-24 13:40:52 PDT
Created attachment 279699 [details] patch for landing
WebKit Commit Bot
Comment 5 2016-05-24 15:27:12 PDT
Comment on attachment 279699 [details] patch for landing Clearing flags on attachment: 279699 Committed r201359: <http://trac.webkit.org/changeset/201359>
WebKit Commit Bot
Comment 6 2016-05-24 15:27:16 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2016-05-31 15:03:00 PDT
Re-opened since this is blocked by bug 158238
Note You need to log in before you can comment on or make changes to this bug.