Bug 157859

Summary:

WebRTC: RTCIceCandidate: Make attributes readonly (and update constructor arg)

Product:

WebKit

Reporter:

Adam Bergkvist <adam.bergkvist>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

143211

Attachments:

Description	Flags
Proposed patch	none

Description Adam Bergkvist 2016-05-18 13:56:29 PDT

According to the latest spec [1]:
- Attributes should be readonly
- Constructor argument is mandatory

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#rtcicecandidate-interface

Comment 1 Adam Bergkvist 2016-05-24 11:06:39 PDT

Created attachment 279673 [details]
Proposed patch

Comment 2 Adam Bergkvist 2016-05-24 13:40:36 PDT

Comment on attachment 279673 [details]
Proposed patch

Thanks Eric!

Comment 3 WebKit Commit Bot 2016-05-24 14:02:44 PDT

Comment on attachment 279673 [details]
Proposed patch

Clearing flags on attachment: 279673

Committed r201350: <http://trac.webkit.org/changeset/201350>

Comment 4 WebKit Commit Bot 2016-05-24 14:02:48 PDT

All reviewed patches have been landed.  Closing bug.