Bug 157859 - WebRTC: RTCIceCandidate: Make attributes readonly (and update constructor arg)
Summary: WebRTC: RTCIceCandidate: Make attributes readonly (and update constructor arg)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency treegraph
 
Reported: 2016-05-18 13:56 PDT by Adam Bergkvist
Modified: 2016-05-24 14:02 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (6.13 KB, patch)
2016-05-24 11:06 PDT, Adam Bergkvist
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-05-18 13:56:29 PDT
According to the latest spec [1]:
- Attributes should be readonly
- Constructor argument is mandatory

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#rtcicecandidate-interface
Comment 1 Adam Bergkvist 2016-05-24 11:06:39 PDT
Created attachment 279673 [details]
Proposed patch
Comment 2 Adam Bergkvist 2016-05-24 13:40:36 PDT
Comment on attachment 279673 [details]
Proposed patch

Thanks Eric!
Comment 3 WebKit Commit Bot 2016-05-24 14:02:44 PDT
Comment on attachment 279673 [details]
Proposed patch

Clearing flags on attachment: 279673

Committed r201350: <http://trac.webkit.org/changeset/201350>
Comment 4 WebKit Commit Bot 2016-05-24 14:02:48 PDT
All reviewed patches have been landed.  Closing bug.