Bug 157642

Summary: Add machine-readable results for JSC API tests to the Buildbot log
Product: WebKit Reporter: Srinivasan Vijayaraghavan <webkit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ggaren
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 157270    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Srinivasan Vijayaraghavan 2016-05-12 15:44:04 PDT 
Add machine-readable results for JSC API tests to the Buildbot log
Comment 1 Srinivasan Vijayaraghavan 2016-05-12 15:47:22 PDT 
Created attachment 278772 [details]
Patch
Comment 2 Srinivasan Vijayaraghavan 2016-05-12 15:52:04 PDT 
Comment on attachment 278772 [details]
Patch

I abstracted out the function that writes JSON to the file. This minimizes the number of conditionals (i.e. checking whether --json-output is specified, which is indicated by $jsonFileName being defined) and also reduces the amount of refactoring. Open to suggestions on how to do this better.
Comment 3 Geoffrey Garen 2016-05-16 11:49:45 PDT 
Comment on attachment 278772 [details]
Patch

r=me
Comment 4 Geoffrey Garen 2016-05-16 11:50:01 PDT 
Would be nice to hook up crash logs to the bot results too.
Comment 5 WebKit Commit Bot 2016-05-16 11:56:31 PDT 
Comment on attachment 278772 [details]
Patch

Clearing flags on attachment: 278772

Committed r200956: <http://trac.webkit.org/changeset/200956>
Comment 6 WebKit Commit Bot 2016-05-16 11:56:36 PDT 
All reviewed patches have been landed.  Closing bug.