Bug 157642

Summary: Add machine-readable results for JSC API tests to the Buildbot log
Product: WebKit Reporter: Srinivasan Vijayaraghavan <webkit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ggaren
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 157270    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Srinivasan Vijayaraghavan
Reported 2016-05-12 15:44:04 PDT
Add machine-readable results for JSC API tests to the Buildbot log
Attachments
Patch (3.43 KB, patch)
2016-05-12 15:47 PDT, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Srinivasan Vijayaraghavan
Comment 1 2016-05-12 15:47:22 PDT
Created attachment 278772 [details] Patch
Srinivasan Vijayaraghavan
Comment 2 2016-05-12 15:52:04 PDT
Comment on attachment 278772 [details] Patch I abstracted out the function that writes JSON to the file. This minimizes the number of conditionals (i.e. checking whether --json-output is specified, which is indicated by $jsonFileName being defined) and also reduces the amount of refactoring. Open to suggestions on how to do this better.
Geoffrey Garen
Comment 3 2016-05-16 11:49:45 PDT
Comment on attachment 278772 [details] Patch r=me
Geoffrey Garen
Comment 4 2016-05-16 11:50:01 PDT
Would be nice to hook up crash logs to the bot results too.
WebKit Commit Bot
Comment 5 2016-05-16 11:56:31 PDT
Comment on attachment 278772 [details] Patch Clearing flags on attachment: 278772 Committed r200956: <http://trac.webkit.org/changeset/200956>
WebKit Commit Bot
Comment 6 2016-05-16 11:56:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.