| Summary: | Optimize layer repaint rects to compute less often | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
| Severity: | Normal | CC: | bburg, buildbot, commit-queue, joepeck, jonlee, nvasilyev, rniwa, simon.fraser | ||||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||||||
| Bug Blocks: | 158079 | ||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Dave Hyatt
2016-05-12 11:42:26 PDT
Created attachment 278741 [details]
Patch
Created attachment 278750 [details]
Patch
Attachment 278750 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderLayer.cpp:861: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:862: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 278750 [details] Patch Attachment 278750 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1311147 New failing tests: svg/custom/svg-percent-scale.html svg/custom/svg-percent-scale-vonly.html fast/repaint/percent-minheight-resize.html fast/repaint/reflection-table-layout.html fast/events/overflow-scroll-fake-mouse-move.html fast/regions/repaint/invalid-region-repaint-crash.html svg/custom/svg-percent-scale-block.html fast/regions/repaint/element-outflow-static-from-inflow-fixed.html Created attachment 278760 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 278750 [details] Patch Attachment 278750 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1311753 Number of test failures exceeded the failure limit. Created attachment 278781 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 278750 [details] Patch Attachment 278750 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1311782 New failing tests: fast/regions/repaint/invalid-region-repaint-crash.html svg/custom/svg-percent-scale-vonly.html svg/custom/svg-percent-scale.html svg/custom/svg-percent-scale-block.html fast/regions/repaint/element-outflow-static-from-inflow-fixed.html Created attachment 278782 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 278750 [details] Patch Attachment 278750 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1313714 New failing tests: svg/custom/svg-percent-scale.html svg/custom/svg-percent-scale-vonly.html fast/repaint/percent-minheight-resize.html fast/repaint/reflection-table-layout.html fast/regions/repaint/invalid-region-repaint-crash.html svg/custom/svg-percent-scale-block.html fast/regions/repaint/element-outflow-static-from-inflow-fixed.html Created attachment 278823 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 278843 [details]
Patch
Comment on attachment 278843 [details] Patch Attachment 278843 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1315712 Number of test failures exceeded the failure limit. Created attachment 278847 [details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 278843 [details] Patch Attachment 278843 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1315745 New failing tests: fast/events/overflow-scroll-fake-mouse-move.html Created attachment 278848 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 279133 [details]
Patch
Comment on attachment 279133 [details] Patch Attachment 279133 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1337293 Number of test failures exceeded the failure limit. Created attachment 279137 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 279160 [details]
Patch
Landed in r201040. *** Bug 156506 has been marked as a duplicate of this bug. *** This broke autocompletion popover in Web Inspector. https://bugs.webkit.org/show_bug.cgi?id=158079#c3 It also caused Data Grid resizing in Web Inspector to have artifacts: https://bugs.webkit.org/show_bug.cgi?id=158165 (In reply to comment #24) > This broke autocompletion popover in Web Inspector. > https://bugs.webkit.org/show_bug.cgi?id=158079#c3 (In reply to comment #25) > It also caused Data Grid resizing in Web Inspector to have artifacts: > https://bugs.webkit.org/show_bug.cgi?id=158165 These have been fixed elsewhere. This caused bug 160551. |