Summary: | Add/refactor isolatedCopy methods for 3 IDB classes | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 149117, 149953 | ||||||||||||||||
Attachments: |
|
Description
Brady Eidson
2016-05-02 17:13:27 PDT
Created attachment 277950 [details]
Patch v1
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1258240 Number of test failures exceeded the failure limit. Created attachment 277951 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1258254 Number of test failures exceeded the failure limit. Created attachment 277952 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1258307 Number of test failures exceeded the failure limit. Created attachment 277954 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1258313 Number of test failures exceeded the failure limit. Created attachment 277956 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Well those failures are obviously tragic. Building locally. Created attachment 277977 [details]
Patch for landing
Comment on attachment 277977 [details] Patch for landing Clearing flags on attachment: 277977 Committed r200372: <http://trac.webkit.org/changeset/200372> All reviewed patches have been landed. Closing bug. Comment on attachment 277977 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=277977&action=review > Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp:85 > + destination.m_identifier = source.m_identifier.isolatedCopy(); aha! |