Bug 157289

Summary: Add/refactor isolatedCopy methods for 3 IDB classes
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 149953    
Attachments:
Description Flags
Patch v1
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Archive of layout-test-results from ews113 for mac-yosemite
none
Patch for landing none

Description Brady Eidson 2016-05-02 17:13:27 PDT
Add/refactor isolatedCopy methods for 3 IDB classes

Needed for upcoming, larger patches.
Comment 1 Brady Eidson 2016-05-02 17:20:25 PDT
Created attachment 277950 [details]
Patch v1
Comment 2 Build Bot 2016-05-02 17:43:56 PDT
Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1258240

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-05-02 17:43:58 PDT
Created attachment 277951 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-05-02 17:45:53 PDT
Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1258254

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-05-02 17:45:56 PDT
Created attachment 277952 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-02 18:10:06 PDT
Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1258307

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-05-02 18:10:08 PDT
Created attachment 277954 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 8 Build Bot 2016-05-02 18:19:01 PDT
Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1258313

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-05-02 18:19:04 PDT
Created attachment 277956 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Brady Eidson 2016-05-02 18:32:12 PDT
Well those failures are obviously tragic. Building locally.
Comment 11 Brady Eidson 2016-05-02 21:43:13 PDT
Created attachment 277977 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2016-05-03 08:30:16 PDT
Comment on attachment 277977 [details]
Patch for landing

Clearing flags on attachment: 277977

Committed r200372: <http://trac.webkit.org/changeset/200372>
Comment 13 WebKit Commit Bot 2016-05-03 08:30:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Alex Christensen 2016-05-03 11:12:38 PDT
Comment on attachment 277977 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=277977&action=review

> Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp:85
> +    destination.m_identifier = source.m_identifier.isolatedCopy();

aha!