| Summary: | Add fail-fast option to run-javascriptcore-tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Srinivasan Vijayaraghavan <webkit> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, commit-queue, ggaren, webkit | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 157642 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Srinivasan Vijayaraghavan
2016-05-02 11:04:03 PDT
Created attachment 277912 [details]
Patch
Comment on attachment 277912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277912&action=review r=me > Tools/Scripts/run-javascriptcore-tests:211 > + if ($failFast) { > + exit exitStatus($testapiResult) if $testapiResult; Since we have two conditions here, I think it's clearer to merge them into one if statement: if ($testapiResult && $failFast) { exit... } Created attachment 277915 [details]
Patch
(In reply to comment #2) > Comment on attachment 277912 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277912&action=review > > r=me > > > Tools/Scripts/run-javascriptcore-tests:211 > > + if ($failFast) { > > + exit exitStatus($testapiResult) if $testapiResult; > > Since we have two conditions here, I think it's clearer to merge them into > one if statement: > > if ($testapiResult && $failFast) { > exit... > } Thanks! I've fixed this. Created attachment 277928 [details]
Patch
Comment on attachment 277928 [details]
Patch
mac-debug failures seem to be unrelated, marking cq+
Comment on attachment 277928 [details] Patch Clearing flags on attachment: 277928 Committed r200339: <http://trac.webkit.org/changeset/200339> All reviewed patches have been landed. Closing bug. |