Summary: | Modern IDB (Workers): More IDBConnectionProxy refactoring | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, aestes, alecflett, cdumez, commit-queue, esprehn+autocc, jsbell, kangil.han | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149117, 149953 | ||||||
Attachments: |
|
Description
Brady Eidson
2016-04-21 11:41:37 PDT
Created attachment 276951 [details]
Patch v1
Attachment 276951 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h:40: Missing space before { [whitespace/braces] [5]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Style issue fixed locally. Comment on attachment 276951 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=276951&action=review > LayoutTests/ChangeLog:8 > + * storage/indexeddb/modern/workers-enable-expected.txt: Revert some of the PASS expectations to FAIL, just for now. Really? (In reply to comment #4) > Comment on attachment 276951 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=276951&action=review > > > LayoutTests/ChangeLog:8 > > + * storage/indexeddb/modern/workers-enable-expected.txt: Revert some of the PASS expectations to FAIL, just for now. > > Really? Yes - It's brand new and in flux, and they'll revert back to PASS in the next couple of patches. |