Summary: | Modern IDB (Workers): Remove IDBRequest/IDBOpenDBRequest's requirement to get an IDBServerConnection around | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, alecflett, commit-queue, jsbell | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149117, 149953 | ||||||
Attachments: |
|
Description
Brady Eidson
2016-04-20 17:13:56 PDT
Created attachment 276874 [details]
Patch v1
Comment on attachment 276874 [details]
Patch v1
r=me.
Do we really need to put "maybe" before the names of all these functions? Doesn't just the fact that they return a RefPtr instead of a Ref imply that they could return nullptr?
(In reply to comment #2) > Comment on attachment 276874 [details] > Patch v1 > > r=me. > Do we really need to put "maybe" before the names of all these functions? > Doesn't just the fact that they return a RefPtr instead of a Ref imply that > they could return nullptr? Back in the days before Ref<>, "maybe" denoted "known to possibly fail" I think it's still common enough that it's worth doing. But, don't worry - the maybe's will go away and revert back to normal "create" once this code push is done! Comment on attachment 276874 [details] Patch v1 Clearing flags on attachment: 276874 Committed r199804: <http://trac.webkit.org/changeset/199804> All reviewed patches have been landed. Closing bug. |