Bug 156272

Summary: Add support for [EnabledAtRuntime] operations on DOMWindow
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cgarcia, commit-queue, ggaren, keith_miller, mark.lam, msaboff, rniwa, saam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=156291
Bug Depends on:    
Bug Blocks: 156113    
Attachments:
Description Flags
WIP Patch for ews
none
WIP Patch for ews
none
Patch none

Chris Dumez
Reported 2016-04-05 18:48:13 PDT
Add support for [EnabledAtRuntime] operation on DOMWindow. We currently support this only for non-Window object. Once this is supported, we can get rid of the hack introduced in: <http://trac.webkit.org/changeset/199081>
Attachments
WIP Patch for ews (3.39 KB, patch)
2016-04-05 21:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch for ews (4.21 KB, patch)
2016-04-05 21:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.53 KB, patch)
2016-04-05 21:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-04-05 21:02:02 PDT
Created attachment 275742 [details] WIP Patch for ews
Chris Dumez
Comment 2 2016-04-05 21:03:41 PDT
Created attachment 275743 [details] WIP Patch for ews
Chris Dumez
Comment 3 2016-04-05 21:57:16 PDT
Created attachment 275752 [details] Patch
Chris Dumez
Comment 4 2016-04-05 21:59:52 PDT
This generates the following in JSDOMWindow::finishCreation(): #if ENABLE(FETCH_API) if (RuntimeEnabledFeatures::sharedFeatures().fetchAPIEnabled()) putDirectNativeFunction(vm, this, vm.propertyNames->fetch, 1, jsDOMWindowInstanceFunctionFetch, NoIntrinsic, attributesForStructure(JSC::Function)); #endif
WebKit Commit Bot
Comment 5 2016-04-05 23:10:35 PDT
Comment on attachment 275752 [details] Patch Clearing flags on attachment: 275752 Committed r199096: <http://trac.webkit.org/changeset/199096>
WebKit Commit Bot
Comment 6 2016-04-05 23:10:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.