Bug 156272

Summary:

Add support for [EnabledAtRuntime] operations on DOMWindow

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cgarcia, commit-queue, ggaren, keith_miller, mark.lam, msaboff, rniwa, saam, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=156291

Bug Depends on:

Bug Blocks:

156113

Attachments:

Description	Flags
WIP Patch for ews	none
WIP Patch for ews	none
Patch	none

Description Chris Dumez 2016-04-05 18:48:13 PDT

Add support for [EnabledAtRuntime] operation on DOMWindow. We currently support this only for non-Window object.
Once this is supported, we can get rid of the hack introduced in:
<http://trac.webkit.org/changeset/199081>

Comment 1 Chris Dumez 2016-04-05 21:02:02 PDT

Created attachment 275742 [details]
WIP Patch for ews

Comment 2 Chris Dumez 2016-04-05 21:03:41 PDT

Created attachment 275743 [details]
WIP Patch for ews

Comment 3 Chris Dumez 2016-04-05 21:57:16 PDT

Created attachment 275752 [details]
Patch

Comment 4 Chris Dumez 2016-04-05 21:59:52 PDT

This generates the following in JSDOMWindow::finishCreation():
#if ENABLE(FETCH_API)
    if (RuntimeEnabledFeatures::sharedFeatures().fetchAPIEnabled())
        putDirectNativeFunction(vm, this, vm.propertyNames->fetch, 1, jsDOMWindowInstanceFunctionFetch, NoIntrinsic, attributesForStructure(JSC::Function));
#endif

Comment 5 WebKit Commit Bot 2016-04-05 23:10:35 PDT

Comment on attachment 275752 [details]
Patch

Clearing flags on attachment: 275752

Committed r199096: <http://trac.webkit.org/changeset/199096>

Comment 6 WebKit Commit Bot 2016-04-05 23:10:42 PDT

All reviewed patches have been landed.  Closing bug.