Bug 155625

Summary: DataView should use an accessor for its length and buffer properties
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=149906
Attachments:
Description Flags
Patch
none
Benchmark results
none
Patch for landing none

Keith Miller
Reported 2016-03-17 21:51:37 PDT
DataView should use an accessor for its length and buffer properties
Attachments
Patch (15.74 KB, patch)
2016-03-17 21:58 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Benchmark results (67.16 KB, text/plain)
2016-03-18 10:11 PDT, Keith Miller 		no flags
Details
Patch for landing (15.73 KB, patch)
2016-03-18 10:42 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-03-17 21:58:18 PDT
Created attachment 274370 [details] Patch
Keith Miller
Comment 2 2016-03-18 10:11:05 PDT
Created attachment 274424 [details] Benchmark results Looks neutral
Michael Saboff
Comment 3 2016-03-18 10:30:22 PDT
Comment on attachment 274370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274370&action=review r=me > Source/JavaScriptCore/ChangeLog:12 > + the object JSArrayBufferView no longer needs to intercept accesses to add change "JSArrayBufferView no" to "JSArrayBufferView, it no"
Keith Miller
Comment 4 2016-03-18 10:42:08 PDT
Created attachment 274427 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-03-18 11:42:58 PDT
Comment on attachment 274427 [details] Patch for landing Clearing flags on attachment: 274427 Committed r198435: <http://trac.webkit.org/changeset/198435>
WebKit Commit Bot
Comment 6 2016-03-18 11:43:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.