Bug 155567

Summary: AX: Implement AutoFill Available attribute for a text field
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, mario, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 9   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch darin: review+

chris fleizach
Reported 2016-03-16 16:47:03 PDT
Make sure auto fill buttons are accessible and that we notify the text field that its available too <rdar://problem/24307473>
Attachments
patch (12.94 KB, patch)
2016-03-16 16:49 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (13.56 KB, patch)
2016-03-16 17:02 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (14.15 KB, patch)
2016-03-16 17:30 PDT, chris fleizach 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2016-03-16 16:49:53 PDT
Created attachment 274235 [details] patch
chris fleizach
Comment 2 2016-03-16 17:02:00 PDT
Created attachment 274239 [details] patch
chris fleizach
Comment 3 2016-03-16 17:30:03 PDT
Created attachment 274245 [details] patch
Darin Adler
Comment 4 2016-03-17 09:25:32 PDT
Comment on attachment 274245 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=274245&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2207 > + if (!node || !is<HTMLInputElement>(*node)) > + return false; This can be written like this: if (!is<HTMLInputElement>(node)) return false; The is<> function does the null check as long as you pass it a pointer rather than a reference.
chris fleizach
Comment 5 2016-03-17 09:29:24 PDT
(In reply to comment #4) > Comment on attachment 274245 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274245&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2207 > > + if (!node || !is<HTMLInputElement>(*node)) > > + return false; > > This can be written like this: > > if (!is<HTMLInputElement>(node)) > return false; > > The is<> function does the null check as long as you pass it a pointer > rather than a reference. Thanks!
chris fleizach
Comment 6 2016-03-17 09:39:37 PDT
http://trac.webkit.org/changeset/198333
Daniel Bates
Comment 7 2016-08-19 15:09:34 PDT
*** Bug 145200 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.