WebRTC: Update RTCIceCandidate

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Adam Bergkvist]

Updates needed to better match the WebRTC 1.0 specification [1]
- "candidate" init dictionary member is required at construction
- At lest one of the "sdpMid" and "sdpMLineIndex" dictionary members must be present at construction
- sdpMid and sdpMLineIndex attributes are nullable 

[1] https://w3c.github.io/webrtc-pc/archives/20160215/webrtc.html

[Adam Bergkvist]

Created attachment 274183 [details]
Proposed patch

[Adam Bergkvist]

Created attachment 274185 [details]
Proposed patch

With mac build fix (unused param)

[Eric Carlson]

Comment on attachment 274185 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274185&action=review

> Source/WebCore/ChangeLog:9
> +        In short: The "candidate" init dictionary member is required. At least one of dictionary

Nit: At least one of *the* ...

> Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:61
> +        if (!intConversionOk || result > 65535) {

Nit: you can use USHRT_MAX here.

[Adam Bergkvist]

Created attachment 274271 [details]
Patch for landing

[Adam Bergkvist]

Thanks for your review Eric. Both comments addressed in patch for landing.

[WebKit Commit Bot]

Comment on attachment 274271 [details]
Patch for landing

Clearing flags on attachment: 274271

Committed r198325: <http://trac.webkit.org/changeset/198325>