Bug 155486

Summary: [css-grid] Rename GridResolvedPosition to GridPositionsResolver
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 153488    
Attachments:
Description Flags
Patch
none
Patch none

Description Manuel Rego Casasnovas 2016-03-15 01:36:27 PDT 
We've a TODO in GridResolvedPosition class:
// TODO(rego): Rename class to GridPositionsResolver.

This was already done in Blink:
https://codereview.chromium.org/1648903002/
Comment 1 Manuel Rego Casasnovas 2016-03-15 01:37:59 PDT 
Created attachment 274082 [details]
Patch
Comment 2 Sergio Villar Senin 2016-03-15 01:47:02 PDT 
Comment on attachment 274082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274082&action=review

r=me provided all the EWS are happy with the rename

> Source/WebCore/rendering/style/GridPositionsResolver.cpp:2
> + * Copyright (C) 2014 Igalia S.L.

Let's use this to update the copyright to 2014, 2016

> Source/WebCore/rendering/style/GridPositionsResolver.cpp:38
> +#include <cstdlib>

Are we really using this include?

> Source/WebCore/rendering/style/GridPositionsResolver.h:2
> + * Copyright (C) 2014 Igalia S.L.

Ditto.
Comment 3 Manuel Rego Casasnovas 2016-03-15 02:49:24 PDT 
Created attachment 274084 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2016-03-15 02:50:34 PDT 
Thanks for the review

(In reply to comment #2)
> > Source/WebCore/rendering/style/GridPositionsResolver.cpp:2
> > + * Copyright (C) 2014 Igalia S.L.
> 
> Let's use this to update the copyright to 2014, 2016

Done.

> 
> > Source/WebCore/rendering/style/GridPositionsResolver.cpp:38
> > +#include <cstdlib>
> 
> Are we really using this include?

We need it for std::abs(int).

> > Source/WebCore/rendering/style/GridPositionsResolver.h:2
> > + * Copyright (C) 2014 Igalia S.L.
> 
> Ditto.

Done.
Comment 5 WebKit Commit Bot 2016-03-15 03:38:30 PDT 
Comment on attachment 274084 [details]
Patch

Clearing flags on attachment: 274084

Committed r198207: <http://trac.webkit.org/changeset/198207>
Comment 6 WebKit Commit Bot 2016-03-15 03:38:35 PDT 
All reviewed patches have been landed.  Closing bug.