Summary: | [css-grid] Fix placement for unknown named grid lines | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, simon.fraser, svillar | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 153488 | ||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2016-03-09 04:49:14 PST
Created attachment 273430 [details]
Patch
Comment on attachment 273430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273430&action=review > Source/WebCore/rendering/style/GridResolvedPosition.cpp:129 > + return end + numberOfLines - 1; I think we can do this in a single line. > Source/WebCore/rendering/style/GridResolvedPosition.cpp:151 > + return start - numberOfLines + 1; Ditto > Source/WebCore/rendering/style/GridResolvedPosition.cpp:167 > + NamedGridLinesMap::const_iterator it = gridLinesNames.find(position.namedGridLine()); We can use auto for these two. Created attachment 273556 [details]
Patch
Thanks for the review, uploaded new patch for landing applying suggested changes. Comment on attachment 273556 [details] Patch Clearing flags on attachment: 273556 Committed r197930: <http://trac.webkit.org/changeset/197930> All reviewed patches have been landed. Closing bug. |