Bug 155065

Summary: Add parsing support for object-position
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, sam, simon.fraser, zalan
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122811    
Attachments:
Description Flags
Patch
none
Patch
sam: review+
Patch
none
Patch simon.fraser: review+

Description Simon Fraser (smfr) 2016-03-05 12:04:09 PST 
First stage of supporting object-position: parsing.
Comment 1 Simon Fraser (smfr) 2016-03-05 12:13:40 PST 
Created attachment 273090 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-03-05 12:27:05 PST 
Created attachment 273092 [details]
Patch
Comment 3 Sam Weinig 2016-03-05 12:33:45 PST 
Comment on attachment 273092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273092&action=review

> Source/WebCore/css/CSSParser.cpp:2891
> +        RefPtr<CSSPrimitiveValue> val1;
> +        RefPtr<CSSPrimitiveValue> val2;

Can we use the whole word here? value1 and value2?

> Source/WebCore/css/StyleBuilderConverter.h:319
> +    Length length;

Please move this to below where it is initialize.
Comment 4 Simon Fraser (smfr) 2016-03-05 12:44:03 PST 
Created attachment 273093 [details]
Patch
Comment 5 Simon Fraser (smfr) 2016-03-05 13:13:38 PST 
Created attachment 273094 [details]
Patch
Comment 6 Simon Fraser (smfr) 2016-03-05 15:25:31 PST 
https://trac.webkit.org/r197617