Summary: | [TextureMapper] Use RGBA format for textures attached to framebuffers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Miguel Gomez <magomez> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, commit-queue, kondapallykalyan, luiz, noam, peavo | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Miguel Gomez
2016-03-03 03:50:42 PST
Created attachment 272751 [details]
Patch
Attachment 272751 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:79: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:91: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 272751 [details] Patch Clearing flags on attachment: 272751 Committed r197506: <http://trac.webkit.org/changeset/197506> All reviewed patches have been landed. Closing bug. There might be a small typo in line 95 in BitmapTexturePool.cpp. Should we be getting the size of m_attachmentTextures instead of m_textures? 93 for (size_t i = 0; i < m_attachmentTextures.size(); ++i) { 94 if (m_attachmentTextures[i].m_lastUsedTime < minUsedTime) { 95 m_attachmentTextures.remove(i, m_textures.size() - i); 96 break; 97 } > There might be a small typo in line 95 in BitmapTexturePool.cpp. > Should we be getting the size of m_attachmentTextures instead of m_textures? > > 93 for (size_t i = 0; i < m_attachmentTextures.size(); ++i) { > 94 if (m_attachmentTextures[i].m_lastUsedTime < minUsedTime) { > 95 m_attachmentTextures.remove(i, m_textures.size() - i); > 96 break; > 97 } You're totally right! I've created a follow up in https://bugs.webkit.org/show_bug.cgi?id=155105 and I'll send a fix in a while. |