Bug 154373

Summary: [SVG] Update SVG source to return string literals as ASCIILiteral and add test cases for case sensitivity
Product: WebKit Reporter: Nikos Andronikos <nikos.andronikos>
Component: SVGAssignee: Nikos Andronikos <nikos.andronikos>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, zimmermann
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nikos Andronikos
Reported 2016-02-17 18:35:37 PST
This patch updates the SVGAnimatedEnumerations toString method to return ASCIILiteral for string literals (as identified in bug 141376, comment 13). The patch also adds test cases for case-sensitivity as required by SVG (as requested in bug 138456, comment 26).
Attachments
Patch (51.28 KB, patch)
2016-02-17 18:44 PST, Nikos Andronikos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikos Andronikos
Comment 1 2016-02-17 18:44:35 PST
Created attachment 271612 [details] Patch
youenn fablet
Comment 2 2016-02-23 07:45:04 PST
Comment on attachment 271612 [details] Patch Looks good to me. Two side notes: 1. It might have been slightly better to split this patch in two parts (going to ASCIILiteral and adding the new case insensitive tests) since they seem to be independent. 2 Regarding the tests, testharness.js would have been a good fit here, especially since the tests are sync It might have made the test expectation a bit easier to read and the test file a bit simpler (no need for debug("") e.g.). The test could also be contributed to W3C test suite.
WebKit Commit Bot
Comment 3 2016-02-23 08:30:46 PST
Comment on attachment 271612 [details] Patch Clearing flags on attachment: 271612 Committed r196977: <http://trac.webkit.org/changeset/196977>
WebKit Commit Bot
Comment 4 2016-02-23 08:30:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.