Bug 154321

Summary: [ES6] Implement revocable proxies
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 35731    
Attachments:
Description Flags
patch
none
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2016-02-16 18:36:28 PST
...
Attachments
patch (35.73 KB, patch)
2016-03-07 18:19 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (36.23 KB, patch)
2016-03-07 18:35 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (36.25 KB, patch)
2016-03-07 20:03 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-07 18:14:43 PST
*** Bug 155135 has been marked as a duplicate of this bug. ***
Saam Barati
Comment 2 2016-03-07 18:19:15 PST
Created attachment 273255 [details] patch
Saam Barati
Comment 3 2016-03-07 18:35:02 PST
Created attachment 273257 [details] patch
Mark Lam
Comment 4 2016-03-07 19:45:34 PST
Comment on attachment 273257 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=273257&action=review r=me > Source/JavaScriptCore/CMakeLists.txt:767 > + runtime/ProxyRevoke.cpp I think you'll also need to add the new files to the vcproj build files. I thought Alex removed them already, but a quick check shows that they are still in the repo.
Saam Barati
Comment 5 2016-03-07 20:03:20 PST
Created attachment 273262 [details] patch for landing lets see if this fixes the build.
WebKit Commit Bot
Comment 6 2016-03-07 23:16:10 PST
Comment on attachment 273262 [details] patch for landing Clearing flags on attachment: 273262 Committed r197732: <http://trac.webkit.org/changeset/197732>
WebKit Commit Bot
Comment 7 2016-03-07 23:16:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.