Bug 154260

Summary: RemoteInspector should forward new automation session requests to its client
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 154012    
Bug Blocks:    
Attachments:
Description Flags
Proposed Fix timothy: review+

Blaze Burg
Reported 2016-02-15 14:27:03 PST
Patch coming.
Attachments
Proposed Fix (4.79 KB, patch)
2016-02-15 15:00 PST, Blaze Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-15 14:27:18 PST
<rdar://problem/24663313>
Blaze Burg
Comment 2 2016-02-15 15:00:39 PST
Created attachment 271375 [details] Proposed Fix
Joseph Pecoraro
Comment 3 2016-02-15 15:12:00 PST
Comment on attachment 271375 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271375&action=review > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:532 > - [listing setObject:target.name() forKey:WIRTitleKey]; > + [listing setObject:target.name() forKey:WIRSessionIdentifierKey]; Shouldn't there be a title? I'd expect something like: [listing setObject:target.name() forKey:WIRTitleKey]; [listing setObject:target.sessionId() forKey:WIRSessionIdentifierKey]; > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:88 > #define WIRAutomationTargetIsPairedKey @"WIRAutomationTargetIsPairedKey" > +#define WIRSessionIdentifierKey @"WIRSessionIdentifierKey" > +#define WIRAutomationSessionRequestMessage @"WIRAutomationSessionRequestMessage" Style: line up
Blaze Burg
Comment 4 2016-02-15 15:45:41 PST
(In reply to comment #3) > Comment on attachment 271375 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271375&action=review > > > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:532 > > - [listing setObject:target.name() forKey:WIRTitleKey]; > > + [listing setObject:target.name() forKey:WIRSessionIdentifierKey]; > > Shouldn't there be a title? I'd expect something like: > > [listing setObject:target.name() forKey:WIRTitleKey]; > [listing setObject:target.sessionId() forKey:WIRSessionIdentifierKey]; sessionIdentifier() is part of WebAutomationSession's interface, not RemoteAutomationTarget. I'm not sure that there is a meaningful user-facing title for an automation session. > > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:88 > > #define WIRAutomationTargetIsPairedKey @"WIRAutomationTargetIsPairedKey" > > +#define WIRSessionIdentifierKey @"WIRSessionIdentifierKey" > > +#define WIRAutomationSessionRequestMessage @"WIRAutomationSessionRequestMessage" > > Style: line up
Blaze Burg
Comment 5 2016-02-16 15:45:25 PST
Committed r196667: <http://trac.webkit.org/changeset/196667>
Note You need to log in before you can comment on or make changes to this bug.