Summary: | EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should be called EditableRoot instead | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, bdakin, enrica, sam, thorton | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Beth Dakin
2016-02-11 16:22:19 PST
Created attachment 271102 [details]
Patch
This is kind of a rubber-stamp situation, but I thought I would post a patch anyway.
Thanks Alexey! http://trac.webkit.org/changeset/196456 Comment on attachment 271102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271102&action=review > Source/WebKit/mac/WebView/WebFrameInternal.h:66 > enum class NSRangeIsRelativeTo : uint8_t { Is it really OK for us to have something that happens to use the NS prefix? I think that’s recipe for conflict with AppKit and Foundation! (In reply to comment #3) > Comment on attachment 271102 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271102&action=review > > > Source/WebKit/mac/WebView/WebFrameInternal.h:66 > > enum class NSRangeIsRelativeTo : uint8_t { > > Is it really OK for us to have something that happens to use the NS prefix? > I think that’s recipe for conflict with AppKit and Foundation! That is very true. I will re-name. (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 271102 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=271102&action=review > > > > > Source/WebKit/mac/WebView/WebFrameInternal.h:66 > > > enum class NSRangeIsRelativeTo : uint8_t { > > > > Is it really OK for us to have something that happens to use the NS prefix? > > I think that’s recipe for conflict with AppKit and Foundation! > > That is very true. I will re-name. I posted a re-name here: https://bugs.webkit.org/show_bug.cgi?id=154174 |